kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-04 04:24:26 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-08-29 17:53:25 +02:00
parent 91b6b86202
commit 19feefda2d
86 changed files with 3173 additions and 2626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests/Unit/Transformers/CategoryTransformerTest.php
View File

@@ -25,13 +25,11 @@ namespace Tests\Unit\Transformers;
use Carbon\Carbon;
use FireflyIII\Models\Category;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
use FireflyIII\Repositories\Category\OperationsRepositoryInterface;
use FireflyIII\Transformers\CategoryTransformer;
use Illuminate\Support\Collection;
use Log;
use Symfony\Component\HttpFoundation\ParameterBag;
use Tests\Support\TestDataTrait;
use Tests\TestCase;
@@ -43,6 +41,8 @@ use Tests\TestCase;
*/
class CategoryTransformerTest extends TestCase
{
use TestDataTrait;
/**
*
*/
@@ -59,8 +59,8 @@ class CategoryTransformerTest extends TestCase
*/
public function testBasic(): void
{
$repository = $this->mock(CategoryRepositoryInterface::class);
$repository->shouldReceive('setUser')->once();
$opsRepository = $this->mock(OperationsRepositoryInterface::class);
$opsRepository->shouldReceive('setUser')->once();
/** @var Category $category */
$category = Category::first();
@@ -80,35 +80,20 @@ class CategoryTransformerTest extends TestCase
*/
public function testWithDates(): void
{
$repository = $this->mock(CategoryRepositoryInterface::class);
$repository->shouldReceive('setUser')->once();
$opsRepository = $this->mock(OperationsRepositoryInterface::class);
$opsRepository->shouldReceive('setUser')->once();
$parameters = new ParameterBag;
$parameters->set('start', new Carbon('2018-01-01'));
$parameters->set('end', new Carbon('2018-01-31'));
// mock some objects for the spent/earned lists.
$expense = [
'currency_id' => 1,
'currency_code' => 'EUR',
'currency_symbol' => '€',
'currency_decimal_places' => 2,
'amount' => -100,
];
$income = [
'currency_id' => 1,
'currency_code' => 'EUR',
'currency_symbol' => '€',
'currency_decimal_places' => 2,
'amount' => 100,
];
$income = $this->categorySumIncome();
$expense = $this->categorySumExpenses();
$opsRepository->shouldReceive('sumIncome')
->atLeast()->once()->andReturn($income);
$incomeCollection = [$income];
$expenseCollection = [$expense];
$repository->shouldReceive('spentInPeriod')->atLeast()->once()->andReturn($expenseCollection);
$repository->shouldReceive('earnedInPeriod')->atLeast()->once()->andReturn($incomeCollection);
$opsRepository->shouldReceive('sumExpenses')
->atLeast()->once()->andReturn($expense);
/** @var Category $category */
$category = Category::first();
@@ -117,27 +102,5 @@ class CategoryTransformerTest extends TestCase
$result = $transformer->transform($category);
$this->assertEquals($category->name, $result['name']);
$this->assertEquals(
[
[
'currency_id' => 1,
'currency_code' => 'EUR',
'currency_symbol' => '€',
'currency_decimal_places' => 2,
'amount' => -100,
],
], $result['spent']
);
$this->assertEquals(
[
[
'currency_id' => 1,
'currency_code' => 'EUR',
'currency_symbol' => '€',
'currency_decimal_places' => 2,
'amount' => 100,
],
], $result['earned']
);
}
}

27
tests/Unit/Transformers/RecurrenceTransformerTest.php
View File

@@ -25,11 +25,13 @@ namespace Tests\Unit\Transformers;
use Carbon\Carbon;
use FireflyIII\Factory\CategoryFactory;
use FireflyIII\Repositories\Bill\BillRepositoryInterface;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
use FireflyIII\Transformers\RecurrenceTransformer;
use FireflyIII\Transformers\RuleGroupTransformer;
use FireflyIII\Transformers\RuleTransformer;
use FireflyIII\Transformers\TagTransformer;
use Log;
use Mockery;
use Symfony\Component\HttpFoundation\ParameterBag;
@@ -59,19 +61,21 @@ class RecurrenceTransformerTest extends TestCase
public function testBasic(): void
{
$recurrenceRepos = $this->mock(RecurringRepositoryInterface::class);
$billRepos = $this->mock(BillRepositoryInterface::class);
$piggyRepos = $this->mock(PiggyBankRepositoryInterface::class);
$factory = $this->mock(CategoryFactory::class);
$budgetRepos = $this->mock(BudgetRepositoryInterface::class);
$category = $this->getRandomCategory();
$budget = $this->getRandomBudget();
$piggy = $this->getRandomPiggyBank();
$bill = $this->getRandomBill();
$ranges = [new Carbon];
$recurrence = $this->getRandomRecurrence();
$ruleGroupTransformer = $this->mock(RuleGroupTransformer::class);
$ruleTransformer = $this->mock(RuleTransformer::class);
$tagTransformer = $this->mock(TagTransformer::class);
$category = $this->getRandomCategory();
$budget = $this->getRandomBudget();
$piggy = $this->getRandomPiggyBank();
$ranges = [new Carbon];
$recurrence = $this->getRandomRecurrence();
// mock calls:
$recurrenceRepos->shouldReceive('setUser')->atLeast()->once();
$billRepos->shouldReceive('setUser')->atLeast()->once();
$piggyRepos->shouldReceive('setUser')->atLeast()->once();
$factory->shouldReceive('setUser')->atLeast()->once();
$budgetRepos->shouldReceive('setUser')->atLeast()->once();
@@ -80,10 +84,9 @@ class RecurrenceTransformerTest extends TestCase
$recurrenceRepos->shouldReceive('getNoteText')->once()->andReturn('Hi there');
$recurrenceRepos->shouldReceive('repetitionDescription')->once()->andReturn('Rep descr');
$recurrenceRepos->shouldReceive('getXOccurrences')->andReturn($ranges)->atLeast()->once();
$factory->shouldReceive('findOrCreate')->atLeast()->once()->withArgs([null,Mockery::any()])->andReturn($category);
$factory->shouldReceive('findOrCreate')->atLeast()->once()->withArgs([null, Mockery::any()])->andReturn($category);
$budgetRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($budget);
$piggyRepos->shouldReceive('findNull')->andReturn($piggy);
$billRepos->shouldReceive('find')->andReturn($bill);
// basic transformation:
@@ -95,7 +98,7 @@ class RecurrenceTransformerTest extends TestCase
$this->assertEquals($recurrence->id, $result['id']);
//$this->assertEquals('deposit', $result['transaction_type']);
$this->assertEquals(true, $result['apply_rules']);
$this->assertEquals('Rep descr', $result['recurrence_repetitions'][0]['description']);
$this->assertEquals('Rep descr', $result['repetitions'][0]['description']);
}

8
tests/Unit/Transformers/RuleTransformerTest.php
View File

@@ -53,13 +53,17 @@ class RuleTransformerTest extends TestCase
$repository = $this->mock(RuleRepositoryInterface::class);
/** @var RuleTrigger $ruleTrigger */
$ruleTrigger = RuleTrigger::first();
$ruleTrigger = RuleTrigger::where('trigger_type', '!=', 'user_action')->first();
/** @var RuleTrigger $ruleTrigger */
$moment = RuleTrigger::where('trigger_type', '=', 'user_action')->first();
/** @var RuleAction $ruleAction */
$ruleAction = RuleAction::first();
// mock stuff
$repository->shouldReceive('setUser')->atLeast()->once();
$repository->shouldReceive('getRuleActions')->atLeast()->once()->andReturn(new Collection([$ruleAction]));
$repository->shouldReceive('getRuleTriggers')->atLeast()->once()->andReturn(new Collection([$ruleTrigger]));
$repository->shouldReceive('getRuleTriggers')->atLeast()->once()->andReturn(new Collection([$moment]), new Collection([$ruleTrigger]));
$transformer = app(RuleTransformer::class);
$transformer->setParameters(new ParameterBag);