Various code cleanup

app/Handlers/Events/StoredJournalEventHandler.php

@@ -125,6 +125,7 @@ class StoredJournalEventHandler
     }
 
     /**
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity) // it's 6 but I can live with it.
      * @param TransactionJournal  $journal
      * @param PiggyBank           $piggyBank
      * @param PiggyBankRepetition $repetition
@@ -153,7 +154,8 @@ class StoredJournalEventHandler
             Log::debug(sprintf('Room in piggy bank for extra money is %f', $room));
             Log::debug(sprintf('There is NO room to add %f to piggy bank #%d ("%s")', $amount, $piggyBank->id, $piggyBank->name));
             Log::debug(sprintf('New amount is %f', $room));
-            $amount = $room;
+
+            return $room;
         }
 
         // amount is negative and $currentamount is smaller than $amount
@@ -161,7 +163,8 @@ class StoredJournalEventHandler
             Log::debug(sprintf('Max amount to remove is %f', $repetition->currentamount));
             Log::debug(sprintf('Cannot remove %f from piggy bank #%d ("%s")', $amount, $piggyBank->id, $piggyBank->name));
             Log::debug(sprintf('New amount is %f', $compare));
-            $amount = $compare;
+
+            return $compare;
         }
 
         return $amount;

app/Handlers/Events/UserEventHandler.php

@@ -85,6 +85,7 @@ class UserEventHandler
     /**
      * @param BlockedBadLogin $event
      *
+     * @deprecated
      * @return bool
      */
     public function reportBadLogin(BlockedBadLogin $event)
@@ -118,6 +119,7 @@ class UserEventHandler
     /**
      * @param BlockedUserLogin $event
      *
+     * @deprecated
      * @return bool
      */
     public function reportBlockedUser(BlockedUserLogin $event): bool
@@ -157,6 +159,7 @@ class UserEventHandler
     /**
      * @param LockedOutUser $event
      *
+     * @deprecated
      * @return bool
      */
     public function reportLockout(LockedOutUser $event): bool
@@ -189,6 +192,7 @@ class UserEventHandler
     /**
      * @param BlockedUseOfDomain $event
      *
+     * @deprecated
      * @return bool
      */
     public function reportUseBlockedDomain(BlockedUseOfDomain $event): bool
@@ -227,6 +231,7 @@ class UserEventHandler
     /**
      * @param BlockedUseOfEmail $event
      *
+     * @deprecated
      * @return bool
      */
     public function reportUseOfBlockedEmail(BlockedUseOfEmail $event): bool
@@ -263,6 +268,7 @@ class UserEventHandler
     /**
      * @param DeletedUser $event
      *
+     * @deprecated
      * @return bool
      */
     public function saveEmailAddress(DeletedUser $event): bool
@@ -379,6 +385,7 @@ class UserEventHandler
      * from the user yet stored conveniently.
      *
      * @param ConfirmedUser $event
+     * @deprecated
      *
      * @return bool
      */
@@ -394,6 +401,7 @@ class UserEventHandler
      * fashion as the previous method.
      *
      * @param RegisteredUser $event
+     * @deprecated
      *
      * @return bool
      */