kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-04 03:43:07 +00:00
Code Issues Projects Releases Wiki Activity

Fix a bunch of phpstan issues.

Browse Source
This commit is contained in:
James Cole
2023-11-28 18:57:10 +01:00
parent b0a39c00ba
commit 1c3cb85a46
31 changed files with 197 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Api/V2/Controllers/Model/BudgetLimit/ListController.php
View File

@@ -51,8 +51,9 @@ class ListController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v2)#/budgets/listBudgetLimitByBudget
* // DateRequest $request, Budget $budget
*/
public function index(DateRequest $request, Budget $budget): JsonResponse
public function index(): JsonResponse
{
return response()->json([]);
// throw new FireflyException('Needs refactoring, move to IndexController.');

4
app/Api/V2/Controllers/Model/PiggyBank/IndexController.php
View File

@@ -60,13 +60,11 @@ class IndexController extends Controller
}
/**
* @param Request $request
*
* TODO see autocomplete/accountcontroller for list.
*
* @return JsonResponse
*/
public function index(Request $request): JsonResponse
public function index(): JsonResponse
{
$piggies = $this->repository->getPiggyBanks();
$pageSize = $this->parameters->get('limit');

1
app/Api/V2/Controllers/Summary/BasicController.php
View File

@@ -100,6 +100,7 @@ class BasicController extends Controller
*
* @return JsonResponse
* @throws Exception
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function basic(DateRequest $request): JsonResponse
{

3
app/Api/V2/Controllers/UserGroup/DestroyController.php
View File

@@ -57,12 +57,11 @@ class DestroyController extends Controller
}
/**
* @param Request $request
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function destroy(Request $request, UserGroup $userGroup): JsonResponse
public function destroy(UserGroup $userGroup): JsonResponse
{
/** @var User $user */
$user = auth()->user();

7
app/Api/V2/Controllers/UserGroup/ShowController.php
View File

@@ -57,11 +57,9 @@ class ShowController extends Controller
}
/**
* @param Request $request
*
* @return JsonResponse
*/
public function index(Request $request): JsonResponse
public function index(): JsonResponse
{
$collection = new Collection();
$pageSize = $this->parameters->get('limit');
@@ -85,12 +83,11 @@ class ShowController extends Controller
}
/**
* @param Request $request
* @param UserGroup $userGroup
*
* @return JsonResponse
*/
public function show(Request $request, UserGroup $userGroup): JsonResponse
public function show(UserGroup $userGroup): JsonResponse
{
$transformer = new UserGroupTransformer();
$transformer->setParameters($this->parameters);

2
app/Api/V2/Request/Autocomplete/AutocompleteRequest.php
View File

@@ -55,8 +55,6 @@ class AutocompleteRequest extends FormRequest
// remove 'initial balance' and another from allowed types. its internal
$array = array_diff($array, [AccountType::INITIAL_BALANCE, AccountType::RECONCILIATION]);
/** @var User $user */
$user = auth()->user();
return [
'types' => $array,