kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 12:12:18 +00:00
Code Issues Projects Releases Wiki Activity

I am changing some string concatenations to sprintf() routines because they are more readable and safer. [skip ci]

Browse Source
This commit is contained in:
James Cole
2016-11-03 21:54:07 +01:00
parent 7bc4c6d115
commit 1d15bc0b10
5 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Support/Preferences.php
View File

@@ -32,7 +32,7 @@ class Preferences
*/
public function delete($name): bool
{
$fullName = 'preference' . auth()->user()->id . $name;
$fullName = sprintf('preference%s%s', auth()->user()->id, $name);
if (Cache::has($fullName)) {
Cache::forget($fullName);
}
@@ -66,7 +66,7 @@ class Preferences
*/
public function getForUser(User $user, $name, $default = null)
{
$fullName = 'preference' . $user->id . $name;
$fullName = sprintf('preference%s%s', $user->id, $name);
if (Cache::has($fullName)) {
return Cache::get($fullName);
}
@@ -138,7 +138,7 @@ class Preferences
*/
public function setForUser(User $user, $name, $value): Preference
{
$fullName = 'preference' . $user->id . $name;
$fullName = sprintf('preference%s%s', $user->id, $name);
Cache::forget($fullName);
$pref = Preference::where('user_id', $user->id)->where('name', $name)->first(['id', 'name', 'data']);