From 29e02ce31f92d5177b497ac45f3ac4fc1a4b7150 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Fri, 6 Oct 2017 07:07:12 +0200
Subject: [PATCH] A longer search string will no longer partly match on account
 name!

---
 app/TransactionRules/Triggers/FromAccountEnds.php | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/TransactionRules/Triggers/FromAccountEnds.php b/app/TransactionRules/Triggers/FromAccountEnds.php
index f0215e96fb..6d56c17dd9 100644
--- a/app/TransactionRules/Triggers/FromAccountEnds.php
+++ b/app/TransactionRules/Triggers/FromAccountEnds.php
@@ -75,10 +75,11 @@ final class FromAccountEnds extends AbstractTrigger implements TriggerInterface
         $searchLength = strlen($search);
 
         // if the string to search for is longer than the account name,
-        // shorten the search string.
+        // it will never be in the account name.
         if ($searchLength > $nameLength) {
-            $search       = substr($search, ($nameLength * -1));
-            $searchLength = strlen($search);
+            Log::debug(sprintf('RuleTrigger FromAccountEnds for journal #%d: "%s" does not end with "%s", return false.', $journal->id, $name, $search));
+
+            return false;
         }