kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 12:12:18 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-06-10 20:14:00 +02:00
parent 8efb73694d
commit 2ab9d2e6ee
75 changed files with 4672 additions and 484 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Models/Account.php
View File

@@ -165,24 +165,6 @@ class Account extends Model
return $name;
}
/**
* Returns the opening balance.
*
* @return TransactionJournal
*/
public function getOpeningBalance(): TransactionJournal
{
$journal = TransactionJournal::leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
->where('transactions.account_id', $this->id)
->transactionTypes([TransactionType::OPENING_BALANCE])
->first(['transaction_journals.*']);
if (null === $journal) {
return new TransactionJournal;
}
return $journal;
}
/**
* @codeCoverageIgnore
* Get all of the notes.

4
app/Models/PiggyBankEvent.php
View File

@@ -38,10 +38,6 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
* @property string $amount
* @property Carbon created_at
* @property Carbon updated_at
* @property \Illuminate\Support\Carbon|null $created_at
* @property \Illuminate\Support\Carbon|null $updated_at
* @property \Illuminate\Support\Carbon $date
* @property-read \FireflyIII\Models\TransactionJournal|null $transactionJournal
* @method static \Illuminate\Database\Eloquent\Builder|\FireflyIII\Models\PiggyBankEvent newModelQuery()
* @method static \Illuminate\Database\Eloquent\Builder|\FireflyIII\Models\PiggyBankEvent newQuery()
* @method static \Illuminate\Database\Eloquent\Builder|\FireflyIII\Models\PiggyBankEvent query()