Improve test coverage.

2026-05-04 21:23:36 +00:00 · 2019-06-10 20:14:00 +02:00
parent 8efb73694d
commit 2ab9d2e6ee
75 changed files with 4672 additions and 484 deletions
--- a/tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
@@ -0,0 +1,129 @@
+<?php
+/**
+ * CCLiabilitiesTest.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace Tests\Unit\Console\Commands\Upgrade;
+
+
+use FireflyConfig;
+use FireflyIII\Models\Account;
+use FireflyIII\Models\AccountType;
+use FireflyIII\Models\Configuration;
+use Log;
+use Tests\TestCase;
+
+/**
+ * Class CCLiabilitiesTest
+ */
+class CCLiabilitiesTest extends TestCase
+{
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::info(sprintf('Now in %s.', get_class($this)));
+    }
+
+    /**
+     * @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
+     */
+    public function testHandle(): void
+    {
+        $false       = new Configuration;
+        $false->data = false;
+        FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
+        FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
+
+
+        $this->artisan('firefly-iii:cc-liabilities')
+             ->expectsOutput('No incorrectly stored credit card liabilities.')
+             ->assertExitCode(0);
+
+        // nothing changed, so nothing to verify.
+    }
+
+    /**
+     * Add type to make the script run.
+     *
+     * @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
+     */
+    public function testHandleEmpty(): void
+    {
+        $type        = AccountType::create(
+            [
+                'type' => AccountType::CREDITCARD,
+            ]
+        );
+        $false       = new Configuration;
+        $false->data = false;
+        FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
+        FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
+
+
+        $this->artisan('firefly-iii:cc-liabilities')
+             ->expectsOutput('No incorrectly stored credit card liabilities.')
+             ->assertExitCode(0);
+        $type->forceDelete();
+        // nothing changed, so nothing to verify.
+    }
+
+    /**
+     * Add some things to make it trigger.
+     *
+     * @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
+     */
+    public function testHandleCase(): void
+    {
+        $type = AccountType::create(
+            [
+                'type' => AccountType::CREDITCARD,
+            ]
+        );
+
+        $account = Account::create(
+            [
+                'name'            => 'CC',
+                'user_id'         => 1,
+                'account_type_id' => $type->id,
+
+            ]
+        );
+
+        $false       = new Configuration;
+        $false->data = false;
+        FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
+        FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
+
+
+        $this->artisan('firefly-iii:cc-liabilities')
+             ->expectsOutput(sprintf('Converted credit card liability account "%s" (#%d) to generic debt liability.', $account->name, $account->id))
+             ->expectsOutput('Credit card liability types are no longer supported and have been converted to generic debts. See: http://bit.ly/FF3-credit-cards')
+             ->assertExitCode(0);
+
+        // verify new type.
+        $this->assertCount(0, Account::where('id', $account->id)->where('account_type_id', $type->id)->get());
+
+        $account->forceDelete();
+        $type->forceDelete();
+
+    }
+}