Code cleanup.

This commit is contained in:
James Cole
2021-03-28 11:43:07 +02:00
parent 5abbb8a807
commit 2c575f3ca5
379 changed files with 304 additions and 1727 deletions

View File

@@ -36,8 +36,6 @@ use Illuminate\Http\Request;
*/
class AutoCompleteController extends Controller
{
/**
* Searches in the titles of all transaction journals.
* The result is limited to the top 15 unique results.
@@ -78,8 +76,6 @@ class AutoCompleteController extends Controller
// give another key for consistency
$array[$index]['name'] = sprintf('#%d: %s', $item['transaction_group_id'], $item['description']);
}
return response()->json($array);
}

View File

@@ -61,8 +61,6 @@ class BoxController extends Controller
$opsRepository = app(OperationsRepositoryInterface::class);
/** @var AvailableBudgetRepositoryInterface $abRepository */
$abRepository = app(AvailableBudgetRepositoryInterface::class);
/** @var Carbon $start */
$start = session('start', Carbon::now()->startOfMonth());
/** @var Carbon $end */
@@ -127,8 +125,6 @@ class BoxController extends Controller
return response()->json($return);
}
/**
* Current total balance.
*
@@ -209,8 +205,6 @@ class BoxController extends Controller
'size' => count($sums),
'preferred' => $currency->id,
];
$cache->store($response);
return response()->json($response);
@@ -256,8 +250,6 @@ class BoxController extends Controller
);
$netWorthSet = $netWorthHelper->getNetWorthByCurrency($filtered, $date);
$return = [];
foreach ($netWorthSet as $data) {
/** @var TransactionCurrency $currency */

View File

@@ -23,8 +23,6 @@
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Json;
use Carbon\Carbon;
use FireflyIII\Http\Controllers\Controller;
use FireflyIII\Models\TransactionCurrency;

View File

@@ -162,8 +162,6 @@ class ReconcileController extends Controller
$view = sprintf('Could not render accounts.reconcile.overview: %s', $e->getMessage());
}
// @codeCoverageIgnoreEnd
$return = [
'post_uri' => $route,
'html' => $view,

View File

@@ -118,8 +118,6 @@ class RecurrenceController extends Controller
$occurrences = $this->recurring->getXOccurrences($repetition, $actualStart, $repetitions);
break;
}
/** @var Carbon $current */
foreach ($occurrences as $current) {
if ($current->gte($start)) {
@@ -179,8 +177,6 @@ class RecurrenceController extends Controller
];
}
Log::debug('Dropdown is', $result);
return response()->json($result);
}
}

View File

@@ -22,8 +22,6 @@
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Json;
use FireflyIII\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
@@ -89,8 +87,6 @@ class RuleController extends Controller
Log::error(sprintf('Cannot render rules.partials.trigger: %s', $e->getMessage()));
$view = 'Could not render view.';
}
return response()->json(['html' => $view]);
}