Code cleanup.

This commit is contained in:
James Cole
2021-03-28 11:43:07 +02:00
parent 5abbb8a807
commit 2c575f3ca5
379 changed files with 304 additions and 1727 deletions

View File

@@ -56,8 +56,6 @@ class BalanceController extends Controller
}
);
}
/**
* Show overview of budget balances.
*
@@ -136,8 +134,6 @@ class BalanceController extends Controller
$report['budgets'][$budgetId]['spent'] = $spent;
// get transactions in budget
}
try {
$result = prefixView('reports.partials.balance', compact('report'))->render();
// @codeCoverageIgnoreStart

View File

@@ -22,8 +22,6 @@
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Report;
use Carbon\Carbon;
use FireflyIII\Helpers\Report\ReportHelperInterface;
use FireflyIII\Http\Controllers\Controller;
@@ -52,13 +50,9 @@ class BillController extends Controller
if ($cache->has()) {
return $cache->get(); // @codeCoverageIgnore
}
/** @var ReportHelperInterface $helper */
$helper = app(ReportHelperInterface::class);
$report = $helper->getBillReport($accounts, $start, $end);
try {
$result = prefixView('reports.partials.bills', compact('report'))->render();
// @codeCoverageIgnoreStart

View File

@@ -321,8 +321,6 @@ class BudgetController extends Controller
$periods = app('navigation')->listOfPeriods($start, $end);
$keyFormat = app('navigation')->preferredCarbonFormat($start, $end);
// list expenses for budgets in account(s)
$expenses = $this->opsRepository->listExpenses($start, $end, $accounts);

View File

@@ -124,8 +124,6 @@ class CategoryController extends Controller
}
}
}
// loop income.
foreach ($earned as $currency) {
$currencyId = $currency['currency_id'];
@@ -143,8 +141,6 @@ class CategoryController extends Controller
'currency_decimal_places' => $currency['currency_decimal_places'],
'categories' => [],
];
$report[$destinationId]['currencies'][$currencyId]['categories'][$category['id']]
= $report[$destinationId]['currencies'][$currencyId]['categories'][$category['id']]
??

View File

@@ -57,8 +57,6 @@ class OperationsController extends Controller
}
);
}
/**
* View of income and expense.
*

View File

@@ -118,8 +118,6 @@ class TagController extends Controller
}
}
}
// loop income.
foreach ($earned as $currency) {
$currencyId = $currency['currency_id'];
@@ -137,8 +135,6 @@ class TagController extends Controller
'currency_decimal_places' => $currency['currency_decimal_places'],
'tags' => [],
];
$report[$destinationId]['currencies'][$currencyId]['tags'][$tag['id']]
= $report[$destinationId]['currencies'][$currencyId]['tags'][$tag['id']]
??