kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-06 04:34:00 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-09-18 10:20:19 +02:00
parent 481a6bdd5f
commit 3589c9f60f
137 changed files with 369 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Http/Controllers/Transaction/BulkController.php
View File

@@ -28,7 +28,10 @@ use FireflyIII\Http\Requests\BulkEditJournalRequest;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Contracts\View\Factory;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\View\View;
use Log;
@@ -90,7 +93,7 @@ class BulkController extends Controller
*
* @param BulkEditJournalRequest $request
*
* @return \Illuminate\Contracts\Foundation\Application|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
* @return Application|RedirectResponse|Redirector
*/
public function update(BulkEditJournalRequest $request)
{

4
app/Http/Controllers/Transaction/DeleteController.php
View File

@@ -26,6 +26,8 @@ namespace FireflyIII\Http\Controllers\Transaction;
use FireflyIII\Http\Controllers\Controller;
use FireflyIII\Models\TransactionGroup;
use FireflyIII\Repositories\TransactionGroup\TransactionGroupRepositoryInterface;
use Illuminate\Contracts\View\Factory;
use Illuminate\Contracts\View\View;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Log;
@@ -66,7 +68,7 @@ class DeleteController extends Controller
*
* @param TransactionGroup $group
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View|Redirector|RedirectResponse
* @return Factory|View|Redirector|RedirectResponse
*/
public function delete(TransactionGroup $group)
{

9
app/Http/Controllers/Transaction/MassController.php
View File

@@ -35,6 +35,7 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Services\Internal\Update\JournalUpdateService;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\View\View as IlluminateView;
@@ -91,7 +92,7 @@ class MassController extends Controller
*
* @param MassDeleteJournalRequest $request
*
* @return \Illuminate\Contracts\Foundation\Application|Redirector|RedirectResponse
* @return Application|Redirector|RedirectResponse
*
*/
public function destroy(MassDeleteJournalRequest $request)
@@ -229,14 +230,14 @@ class MassController extends Controller
/**
* @param MassEditJournalRequest $request
* @param int $journalId
* @param string $string
* @param string $key
*
* @return Carbon|null
* @codeCoverageIgnore
*/
private function getDateFromRequest(MassEditJournalRequest $request, int $journalId, string $string): ?Carbon
private function getDateFromRequest(MassEditJournalRequest $request, int $journalId, string $key): ?Carbon
{
$value = $request->get($string);
$value = $request->get($key);
if (!is_array($value)) {
return null;
}