kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-12 01:42:32 +00:00
Code Issues Projects Releases Wiki Activity

Fix various phpstan errors.

Browse Source
This commit is contained in:
James Cole
2023-11-01 18:45:15 +01:00
parent 4ee3c7d83e
commit 3b4b074bae
14 changed files with 49 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Console/Commands/Correction/FixUnevenAmount.php
View File

@@ -55,7 +55,7 @@ class FixUnevenAmount extends Command
/** @var stdClass $entry */
foreach ($journals as $entry) {
$sum = (string)$entry->the_sum;
if (!is_numeric($sum) || '' === $sum || str_contains($sum, 'e') || str_contains($sum, ',')) {
if (!is_numeric($sum) || 0 === strlen($sum) || str_contains($sum, 'e') || str_contains($sum, ',')) {
$message = sprintf(
'Journal #%d has an invalid sum ("%s"). No sure what to do.',
$entry->transaction_journal_id,

2
app/Console/Commands/Export/ExportData.php
View File

@@ -268,7 +268,7 @@ class ExportData extends Command
private function getExportDirectory(): string
{
$directory = (string)$this->option('export_directory');
if (null === $directory) {
if ('' === $directory) {
$directory = './';
}
if (!is_writable($directory)) {

4
app/Console/Commands/System/ForceDecimalSize.php
View File

@@ -501,8 +501,8 @@ class ForceDecimalSize extends Command
/** @var Transaction $item */
foreach ($result as $item) {
$value = $item->amount;
if (null === $value) {
$value = (string)$item->amount;
if ('' === $value) {
continue;
}
// fix $field by rounding it down correctly.

3
app/Console/Commands/Upgrade/UpgradeCurrencyPreferences.php
View File

@@ -35,7 +35,6 @@ use Illuminate\Support\Collection;
/**
* Class UpgradeCurrencyPreferences
* TODO DONT FORGET TO ADD THIS TO THE DOCKER BUILD
*/
class UpgradeCurrencyPreferences extends Command
{
@@ -71,7 +70,7 @@ class UpgradeCurrencyPreferences extends Command
$this->friendlyPositive('Currency preferences migrated.');
//$this->markAsExecuted();
$this->markAsExecuted();
return 0;
}

12
app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php
View File

@@ -246,14 +246,14 @@ class UpgradeLiabilitiesEight extends Command
}
// overruled. No transaction will be deleted, ever.
// code is kept in place so i can revisit my reasoning.
// code is kept in place so I can revisit my reasoning.
$delete = false;
if ($delete) {
$service = app(TransactionGroupDestroyService::class);
$service->destroy($journal->transactionGroup);
$count++;
}
// if ($delete) {
$service = app(TransactionGroupDestroyService::class);
$service->destroy($journal->transactionGroup);
$count++;
// }
}
return $count;