Fix various phpstan errors.

This commit is contained in:
James Cole
2023-11-01 18:45:15 +01:00
parent 4ee3c7d83e
commit 3b4b074bae
14 changed files with 49 additions and 66 deletions

View File

@@ -35,7 +35,6 @@ use Illuminate\Support\Collection;
/**
* Class UpgradeCurrencyPreferences
* TODO DONT FORGET TO ADD THIS TO THE DOCKER BUILD
*/
class UpgradeCurrencyPreferences extends Command
{
@@ -71,7 +70,7 @@ class UpgradeCurrencyPreferences extends Command
$this->friendlyPositive('Currency preferences migrated.');
//$this->markAsExecuted();
$this->markAsExecuted();
return 0;
}

View File

@@ -246,14 +246,14 @@ class UpgradeLiabilitiesEight extends Command
}
// overruled. No transaction will be deleted, ever.
// code is kept in place so i can revisit my reasoning.
// code is kept in place so I can revisit my reasoning.
$delete = false;
if ($delete) {
$service = app(TransactionGroupDestroyService::class);
$service->destroy($journal->transactionGroup);
$count++;
}
// if ($delete) {
$service = app(TransactionGroupDestroyService::class);
$service->destroy($journal->transactionGroup);
$count++;
// }
}
return $count;