kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 04:03:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix #3880

Browse Source
This commit is contained in:
James Cole
2020-10-01 10:50:34 +02:00
parent df8c6abd5c
commit 3ce949f0aa
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Api/V1/Controllers/PiggyBankController.php
View File

@@ -43,9 +43,7 @@ use League\Fractal\Resource\Item;
*/ */
class PiggyBankController extends Controller class PiggyBankController extends Controller
{ {
/** @var PiggyBankRepositoryInterface The piggy bank repository */ private PiggyBankRepositoryInterface $repository;
private $repository;
/** /**
* PiggyBankController constructor. * PiggyBankController constructor.

8
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@@ -437,9 +437,9 @@ trait ModifiesPiggyBanks
//piggy zelf naar 7 //piggy zelf naar 7
/** @var User $user */ /** @var User $user */
$user = $this->user; $user = $this->user;
$user->piggyBanks()->where('order', '<=', $newOrder)->where('order', '>', $oldOrder) $user->piggyBanks()->where('piggy_banks.order', '<=', $newOrder)->where('piggy_banks.order', '>', $oldOrder)
->where('piggy_banks.id', '!=', $piggyBank->id) ->where('piggy_banks.id', '!=', $piggyBank->id)
->update(['order' => DB::raw('piggy_banks.order-1')]); ->update(['piggy_banks.order' => DB::raw('piggy_banks.order-1')]);
$piggyBank->order = $newOrder; $piggyBank->order = $newOrder;
$piggyBank->save(); $piggyBank->save();
} }
@@ -450,9 +450,9 @@ trait ModifiesPiggyBanks
// 8 naar 2 // 8 naar 2
/** @var User $user */ /** @var User $user */
$user = $this->user; $user = $this->user;
$user->piggyBanks()->where('order', '>=', $newOrder)->where('order', '<', $oldOrder) $user->piggyBanks()->where('piggy_banks.order', '>=', $newOrder)->where('piggy_banks.order', '<', $oldOrder)
->where('piggy_banks.id', '!=', $piggyBank->id) ->where('piggy_banks.id', '!=', $piggyBank->id)
->update(['order' => DB::raw('piggy_banks.order+1')]); ->update(['piggy_banks.order' => DB::raw('piggy_banks.order+1')]);
$piggyBank->order = $newOrder; $piggyBank->order = $newOrder;
$piggyBank->save(); $piggyBank->save();
} }