From 3f493aceb2a9ec4765d03c207f2a22f56ff071a5 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 23 Aug 2018 18:33:07 +0200 Subject: [PATCH] Mark code as untestable or deprecated (or both). --- app/Console/Commands/CreateExport.php | 2 ++ app/Console/Commands/CreateImport.php | 2 ++ app/Console/Commands/Cron.php | 2 ++ app/Console/Commands/DecryptAttachment.php | 2 ++ app/Console/Commands/EncryptFile.php | 2 ++ app/Console/Commands/Import.php | 2 ++ app/Console/Commands/ScanAttachments.php | 2 ++ app/Console/Commands/UpgradeDatabase.php | 1 + app/Console/Commands/UpgradeFireflyInstructions.php | 2 ++ app/Console/Commands/UseEncryption.php | 1 + app/Console/Commands/VerifiesAccessToken.php | 1 + app/Console/Commands/VerifyDatabase.php | 1 + app/Console/Kernel.php | 1 + app/Events/AdminRequestedTestMessage.php | 1 + app/Events/Event.php | 1 + app/Events/RegisteredUser.php | 1 + app/Events/RequestedNewPassword.php | 1 + app/Events/RequestedReportOnJournals.php | 2 ++ app/Events/RequestedVersionCheckStatus.php | 2 ++ app/Events/UserChangedEmail.php | 2 ++ app/Exceptions/Handler.php | 1 + app/Export/Collector/AttachmentCollector.php | 3 +++ app/Export/Collector/BasicCollector.php | 3 +++ app/Export/Collector/CollectorInterface.php | 3 +++ app/Export/Collector/UploadCollector.php | 3 +++ app/Export/Entry/Entry.php | 3 +++ app/Export/ExpandedProcessor.php | 3 +++ app/Export/Exporter/BasicExporter.php | 3 +++ app/Export/Exporter/CsvExporter.php | 3 +++ app/Export/Exporter/ExporterInterface.php | 3 +++ app/Export/ProcessorInterface.php | 3 +++ 31 files changed, 62 insertions(+) diff --git a/app/Console/Commands/CreateExport.php b/app/Console/Commands/CreateExport.php index 6896b409cf..73b4d3384f 100644 --- a/app/Console/Commands/CreateExport.php +++ b/app/Console/Commands/CreateExport.php @@ -39,6 +39,8 @@ use Storage; * Class CreateExport. * * Generates export from the command line. + * + * @codeCoverageIgnore */ class CreateExport extends Command { diff --git a/app/Console/Commands/CreateImport.php b/app/Console/Commands/CreateImport.php index 2479ac514f..15234cb3aa 100644 --- a/app/Console/Commands/CreateImport.php +++ b/app/Console/Commands/CreateImport.php @@ -37,6 +37,8 @@ use Log; /** * Class CreateImport. + * + * @codeCoverageIgnore */ class CreateImport extends Command { diff --git a/app/Console/Commands/Cron.php b/app/Console/Commands/Cron.php index 4678382102..807de0c39f 100644 --- a/app/Console/Commands/Cron.php +++ b/app/Console/Commands/Cron.php @@ -8,6 +8,8 @@ use Illuminate\Console\Command; /** * Class Cron + * + * @codeCoverageIgnore */ class Cron extends Command { diff --git a/app/Console/Commands/DecryptAttachment.php b/app/Console/Commands/DecryptAttachment.php index dfa57386e5..450eedd8bd 100644 --- a/app/Console/Commands/DecryptAttachment.php +++ b/app/Console/Commands/DecryptAttachment.php @@ -31,6 +31,8 @@ use Log; /** * Class DecryptAttachment. + * + * @codeCoverageIgnore */ class DecryptAttachment extends Command { diff --git a/app/Console/Commands/EncryptFile.php b/app/Console/Commands/EncryptFile.php index 64b19820a5..08d9683afa 100644 --- a/app/Console/Commands/EncryptFile.php +++ b/app/Console/Commands/EncryptFile.php @@ -29,6 +29,8 @@ use Illuminate\Console\Command; /** * Class EncryptFile. + * + * @codeCoverageIgnore */ class EncryptFile extends Command { diff --git a/app/Console/Commands/Import.php b/app/Console/Commands/Import.php index b7572cf061..7ee59ea03b 100644 --- a/app/Console/Commands/Import.php +++ b/app/Console/Commands/Import.php @@ -35,6 +35,8 @@ use Log; /** * Class Import. + * + * @codeCoverageIgnore */ class Import extends Command { diff --git a/app/Console/Commands/ScanAttachments.php b/app/Console/Commands/ScanAttachments.php index cd76aa9377..034a1c2fa3 100644 --- a/app/Console/Commands/ScanAttachments.php +++ b/app/Console/Commands/ScanAttachments.php @@ -34,6 +34,8 @@ use Storage; /** * Class ScanAttachments. + * + * @codeCoverageIgnore */ class ScanAttachments extends Command { diff --git a/app/Console/Commands/UpgradeDatabase.php b/app/Console/Commands/UpgradeDatabase.php index b126e38850..b1b393398b 100644 --- a/app/Console/Commands/UpgradeDatabase.php +++ b/app/Console/Commands/UpgradeDatabase.php @@ -63,6 +63,7 @@ use UnexpectedValueException; * Upgrade user database. * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @codeCoverageIgnore */ class UpgradeDatabase extends Command { diff --git a/app/Console/Commands/UpgradeFireflyInstructions.php b/app/Console/Commands/UpgradeFireflyInstructions.php index 9aa8f33a1e..37cd28f4ea 100644 --- a/app/Console/Commands/UpgradeFireflyInstructions.php +++ b/app/Console/Commands/UpgradeFireflyInstructions.php @@ -27,6 +27,8 @@ use Illuminate\Console\Command; /** * Class UpgradeFireflyInstructions. + * + * @codeCoverageIgnore */ class UpgradeFireflyInstructions extends Command { diff --git a/app/Console/Commands/UseEncryption.php b/app/Console/Commands/UseEncryption.php index 7a67d71cf6..55ef87eee9 100644 --- a/app/Console/Commands/UseEncryption.php +++ b/app/Console/Commands/UseEncryption.php @@ -28,6 +28,7 @@ use Illuminate\Support\Str; /** * Class UseEncryption. + * @codeCoverageIgnore */ class UseEncryption extends Command { diff --git a/app/Console/Commands/VerifiesAccessToken.php b/app/Console/Commands/VerifiesAccessToken.php index 857aeaa30b..a0224ae0d6 100644 --- a/app/Console/Commands/VerifiesAccessToken.php +++ b/app/Console/Commands/VerifiesAccessToken.php @@ -30,6 +30,7 @@ use Log; * Trait VerifiesAccessToken. * * Verifies user access token for sensitive commands. + * @codeCoverageIgnore */ trait VerifiesAccessToken { diff --git a/app/Console/Commands/VerifyDatabase.php b/app/Console/Commands/VerifyDatabase.php index 88635664ae..31b8b89658 100644 --- a/app/Console/Commands/VerifyDatabase.php +++ b/app/Console/Commands/VerifyDatabase.php @@ -50,6 +50,7 @@ use stdClass; * * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @codeCoverageIgnore */ class VerifyDatabase extends Command { diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php index 250b83f5bc..1b3fdb5311 100644 --- a/app/Console/Kernel.php +++ b/app/Console/Kernel.php @@ -30,6 +30,7 @@ use Log; /** * File to make sure commands work. + * @codeCoverageIgnore */ class Kernel extends ConsoleKernel { diff --git a/app/Events/AdminRequestedTestMessage.php b/app/Events/AdminRequestedTestMessage.php index 800ffb909f..0a82c434cc 100644 --- a/app/Events/AdminRequestedTestMessage.php +++ b/app/Events/AdminRequestedTestMessage.php @@ -30,6 +30,7 @@ use Log; /** * Class AdminRequestedTestMessage. + * @codeCoverageIgnore */ class AdminRequestedTestMessage extends Event { diff --git a/app/Events/Event.php b/app/Events/Event.php index 41b3b0437c..84ea6bdb2b 100644 --- a/app/Events/Event.php +++ b/app/Events/Event.php @@ -26,6 +26,7 @@ namespace FireflyIII\Events; /** * Class Event. + * @codeCoverageIgnore */ abstract class Event { diff --git a/app/Events/RegisteredUser.php b/app/Events/RegisteredUser.php index 1bbb4b25dd..c576b16f94 100644 --- a/app/Events/RegisteredUser.php +++ b/app/Events/RegisteredUser.php @@ -29,6 +29,7 @@ use Illuminate\Queue\SerializesModels; /** * Class RegisteredUser. + * @codeCoverageIgnore */ class RegisteredUser extends Event { diff --git a/app/Events/RequestedNewPassword.php b/app/Events/RequestedNewPassword.php index ffd13ee344..7dce83c05d 100644 --- a/app/Events/RequestedNewPassword.php +++ b/app/Events/RequestedNewPassword.php @@ -29,6 +29,7 @@ use Illuminate\Queue\SerializesModels; /** * Class RequestedNewPassword. + * @codeCoverageIgnore */ class RequestedNewPassword extends Event { diff --git a/app/Events/RequestedReportOnJournals.php b/app/Events/RequestedReportOnJournals.php index 9d9c0444a6..0bd2ac4c55 100644 --- a/app/Events/RequestedReportOnJournals.php +++ b/app/Events/RequestedReportOnJournals.php @@ -31,6 +31,8 @@ use Log; /** * Class RequestedReportOnJournals + * + * @codeCoverageIgnore */ class RequestedReportOnJournals { diff --git a/app/Events/RequestedVersionCheckStatus.php b/app/Events/RequestedVersionCheckStatus.php index dabe9ca7b8..a490ea0e38 100644 --- a/app/Events/RequestedVersionCheckStatus.php +++ b/app/Events/RequestedVersionCheckStatus.php @@ -30,6 +30,8 @@ use Illuminate\Queue\SerializesModels; /** * Class RequestedVersionCheckStatus + * + * @codeCoverageIgnore */ class RequestedVersionCheckStatus extends Event { diff --git a/app/Events/UserChangedEmail.php b/app/Events/UserChangedEmail.php index 917eef90ae..12e7aab446 100644 --- a/app/Events/UserChangedEmail.php +++ b/app/Events/UserChangedEmail.php @@ -29,6 +29,8 @@ use Illuminate\Queue\SerializesModels; /** * Class UserChangedEmail. + * + * @codeCoverageIgnore */ class UserChangedEmail extends Event { diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php index 5d6899c52b..72caac1261 100644 --- a/app/Exceptions/Handler.php +++ b/app/Exceptions/Handler.php @@ -38,6 +38,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; /** * Class Handler + * @codeCoverageIgnore */ class Handler extends ExceptionHandler { diff --git a/app/Export/Collector/AttachmentCollector.php b/app/Export/Collector/AttachmentCollector.php index 49e8b1e20a..a0a354451b 100644 --- a/app/Export/Collector/AttachmentCollector.php +++ b/app/Export/Collector/AttachmentCollector.php @@ -34,6 +34,9 @@ use Storage; /** * Class AttachmentCollector. + * + * @deprecated + * @codeCoverageIgnore */ class AttachmentCollector extends BasicCollector implements CollectorInterface { diff --git a/app/Export/Collector/BasicCollector.php b/app/Export/Collector/BasicCollector.php index 10215d6c58..c1db2a82a3 100644 --- a/app/Export/Collector/BasicCollector.php +++ b/app/Export/Collector/BasicCollector.php @@ -30,6 +30,9 @@ use Illuminate\Support\Collection; /** * Class BasicCollector. + * + * @codeCoverageIgnore + * @deprecated */ class BasicCollector { diff --git a/app/Export/Collector/CollectorInterface.php b/app/Export/Collector/CollectorInterface.php index b93dc1617b..c58e538ee1 100644 --- a/app/Export/Collector/CollectorInterface.php +++ b/app/Export/Collector/CollectorInterface.php @@ -29,6 +29,9 @@ use Illuminate\Support\Collection; /** * Interface CollectorInterface. + * + * @codeCoverageIgnore + * @deprecated */ interface CollectorInterface { diff --git a/app/Export/Collector/UploadCollector.php b/app/Export/Collector/UploadCollector.php index 5e1e6df02b..e2637b940f 100644 --- a/app/Export/Collector/UploadCollector.php +++ b/app/Export/Collector/UploadCollector.php @@ -31,6 +31,9 @@ use Storage; /** * Class UploadCollector. + * + * @codeCoverageIgnore + * @deprecated */ class UploadCollector extends BasicCollector implements CollectorInterface { diff --git a/app/Export/Entry/Entry.php b/app/Export/Entry/Entry.php index 8543c75646..9e0064d58e 100644 --- a/app/Export/Entry/Entry.php +++ b/app/Export/Entry/Entry.php @@ -43,6 +43,9 @@ use FireflyIII\Models\Transaction; * * @SuppressWarnings(PHPMD.LongVariable) * @SuppressWarnings(PHPMD.TooManyFields) + * + * @codeCoverageIgnore + * @deprecated */ final class Entry { diff --git a/app/Export/ExpandedProcessor.php b/app/Export/ExpandedProcessor.php index 1734713aa0..4adb9499cf 100644 --- a/app/Export/ExpandedProcessor.php +++ b/app/Export/ExpandedProcessor.php @@ -49,6 +49,9 @@ use ZipArchive; * Class ExpandedProcessor. * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) // its doing a lot. + * + * @codeCoverageIgnore + * @deprecated */ class ExpandedProcessor implements ProcessorInterface { diff --git a/app/Export/Exporter/BasicExporter.php b/app/Export/Exporter/BasicExporter.php index fd1003ddfa..de7eaed474 100644 --- a/app/Export/Exporter/BasicExporter.php +++ b/app/Export/Exporter/BasicExporter.php @@ -29,6 +29,9 @@ use Illuminate\Support\Collection; /** * Class BasicExporter. + * + * @codeCoverageIgnore + * @deprecated */ class BasicExporter { diff --git a/app/Export/Exporter/CsvExporter.php b/app/Export/Exporter/CsvExporter.php index bbc66b8345..6e4a7b96d1 100644 --- a/app/Export/Exporter/CsvExporter.php +++ b/app/Export/Exporter/CsvExporter.php @@ -30,6 +30,9 @@ use Storage; /** * Class CsvExporter. + * + * @codeCoverageIgnore + * @deprecated */ class CsvExporter extends BasicExporter implements ExporterInterface { diff --git a/app/Export/Exporter/ExporterInterface.php b/app/Export/Exporter/ExporterInterface.php index cc44b69c08..998510f65b 100644 --- a/app/Export/Exporter/ExporterInterface.php +++ b/app/Export/Exporter/ExporterInterface.php @@ -29,6 +29,9 @@ use Illuminate\Support\Collection; /** * Interface ExporterInterface. + * + * @codeCoverageIgnore + * @deprecated */ interface ExporterInterface { diff --git a/app/Export/ProcessorInterface.php b/app/Export/ProcessorInterface.php index 641e26eaeb..330e69c2d2 100644 --- a/app/Export/ProcessorInterface.php +++ b/app/Export/ProcessorInterface.php @@ -28,6 +28,9 @@ use Illuminate\Support\Collection; /** * Interface ProcessorInterface. + * + * @codeCoverageIgnore + * @deprecated */ interface ProcessorInterface {