kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-04 03:43:07 +00:00
Code Issues Projects Releases Wiki Activity

feat: surface expression validation errors when creating or updating rules

Browse Source
This commit is contained in:
Michael Thomas
2024-03-07 12:23:32 -05:00
parent b572c1dcd3
commit 438f602961
7 changed files with 58 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/Api/V1/Controllers/Models/Rule/ExpressionController.php
View File

@@ -74,15 +74,14 @@ class ExpressionController extends Controller
$expressionLanguage = ExpressionLanguageFactory::get();
$evaluator = new ActionExpressionEvaluator($expressionLanguage, $expr);
try {
$evaluator->lint();
if ($evaluator->isValid()) {
return response()->json([
"valid" => true,
]);
} catch (SyntaxError $e) {
} else {
return response()->json([
"valid" => false,
"error" => $e->getMessage()
"error" => $evaluator->getValidationError()->getMessage()
]);
}
}