kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-11 09:29:34 +00:00
Code Issues Projects Releases Wiki Activity

Replace enum

Browse Source
This commit is contained in:
James Cole
2025-01-03 09:05:19 +01:00
parent 21165eb3e0
commit 44eafeeae5
55 changed files with 148 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Validation/AccountValidator.php
View File

@@ -25,6 +25,7 @@ declare(strict_types=1);
namespace FireflyIII\Validation;
use FireflyIII\Enums\AccountTypeEnum;
use FireflyIII\Enums\TransactionTypeEnum;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionType;
use FireflyIII\Models\UserGroup;
@@ -140,7 +141,7 @@ class AccountValidator
break;
case TransactionType::WITHDRAWAL:
case TransactionTypeEnum::WITHDRAWAL->value:
$result = $this->validateWithdrawalDestination($array);
break;
@@ -185,7 +186,7 @@ class AccountValidator
break;
case TransactionType::WITHDRAWAL:
case TransactionTypeEnum::WITHDRAWAL->value:
$result = $this->validateWithdrawalSource($array);
break;

3
app/Validation/TransactionValidation.php
View File

@@ -24,6 +24,7 @@ declare(strict_types=1);
namespace FireflyIII\Validation;
use FireflyIII\Enums\TransactionTypeEnum;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
@@ -259,7 +260,7 @@ trait TransactionValidation
return;
}
}
if (TransactionType::TRANSFER === ucfirst($transactionType) || TransactionType::WITHDRAWAL === ucfirst($transactionType)) {
if (TransactionType::TRANSFER === ucfirst($transactionType) || TransactionTypeEnum::WITHDRAWAL->value === ucfirst($transactionType)) {
app('log')->debug(sprintf('Processing as a "%s"', $transactionType));
// use case: withdrawal from asset account to a liability account.
// the foreign amount must be in the currency of the destination