Add API route to move transactions from one account to another.

2025-09-05 04:03:26 +00:00 · 2021-04-03 13:56:45 +02:00
parent 51f3b17ad2
commit 468a53d587
5 changed files with 186 additions and 1 deletions
--- a/app/Api/V1/Requests/Data/Bulk/MoveTransactionsRequest.php
+++ b/app/Api/V1/Requests/Data/Bulk/MoveTransactionsRequest.php
@@ -0,0 +1,104 @@
+<?php
+/*
+ * MoveTransactionsRequest.php
+ * Copyright (c) 2021 james@firefly-iii.org
+ *
+ * This file is part of Firefly III (https://github.com/firefly-iii).
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Api\V1\Requests\Data\Bulk;
+
+use FireflyIII\Repositories\Account\AccountRepositoryInterface;
+use FireflyIII\Support\Request\ChecksLogin;
+use FireflyIII\Support\Request\ConvertsDataTypes;
+use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Validator;
+
+/**
+ * Class MoveTransactionsRequest
+ */
+class MoveTransactionsRequest extends FormRequest
+{
+    use ChecksLogin, ConvertsDataTypes;
+
+    /**
+     * @return array
+     */
+    public function getAll(): array
+    {
+        return [
+            'original_account'    => $this->integer('original_account'),
+            'destination_account' => $this->integer('destination_account'),
+        ];
+    }
+
+    /**
+     * @return string[]
+     */
+    public function rules(): array
+    {
+        return [
+            'original_account'    => 'required|different:destination_account|belongsToUser:accounts,id',
+            'destination_account' => 'required|different:original_account|belongsToUser:accounts,id',
+        ];
+    }
+
+    /**
+     * Configure the validator instance with special rules for after the basic validation rules.
+     *
+     * @param Validator $validator
+     *                            TODO duplicate code.
+     *
+     * @return void
+     */
+    public function withValidator(Validator $validator): void
+    {
+        $validator->after(
+            function (Validator $validator) {
+                // validate start before end only if both are there.
+                $data = $validator->getData();
+                if (array_key_exists('original_account', $data) && array_key_exists('destination_account', $data)) {
+                    $repository = app(AccountRepositoryInterface::class);
+                    $repository->setUser(auth()->user());
+                    $original    = $repository->findNull((int)$data['original_account']);
+                    $destination = $repository->findNull((int)$data['destination_account']);
+                    if ($original->accountType->type !== $destination->accountType->type) {
+                        $validator->errors()->add('title', (string)trans('validation.same_account_type'));
+
+                        return;
+                    }
+                    // get currency pref:
+                    $originalCurrency    = $repository->getAccountCurrency($original);
+                    $destinationCurrency = $repository->getAccountCurrency($destination);
+                    if (null === $originalCurrency xor null === $destinationCurrency) {
+                        $validator->errors()->add('title', (string)trans('validation.same_account_currency'));
+
+                        return;
+                    }
+                    if (null === $originalCurrency && null === $destinationCurrency) {
+                        // this is OK
+                        return;
+                    }
+                    if ($originalCurrency->code !== $destinationCurrency->code) {
+                        $validator->errors()->add('title', (string)trans('validation.same_account_currency'));
+
+                        return;
+                    }
+                }
+            }
+        );
+    }
+}