From 49013264d586cc957a00309e93c4831a9c365b91 Mon Sep 17 00:00:00 2001
From: James Cole <james@firefly-iii.org>
Date: Wed, 7 Apr 2021 07:32:54 +0200
Subject: [PATCH] Various code cleanup.

---
 app/Http/Controllers/ProfileController.php        | 1 +
 app/Http/Controllers/System/InstallController.php | 3 +--
 app/Models/TransactionJournal.php                 | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php
index e4f0d932ca..5163730398 100644
--- a/app/Http/Controllers/ProfileController.php
+++ b/app/Http/Controllers/ProfileController.php
@@ -207,6 +207,7 @@ class ProfileController extends Controller
         }
 
         // generate codes if not in session:
+        $recoveryCodes = '';
         if (!session()->has('temp-mfa-codes')) {
             // generate codes + store + flash:
             $recovery      = app(Recovery::class);
diff --git a/app/Http/Controllers/System/InstallController.php b/app/Http/Controllers/System/InstallController.php
index 931c0a3725..ad808437e3 100644
--- a/app/Http/Controllers/System/InstallController.php
+++ b/app/Http/Controllers/System/InstallController.php
@@ -32,7 +32,6 @@ use FireflyIII\Support\Http\Controllers\GetConfigurationData;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
-use Illuminate\Support\Arr;
 use Illuminate\View\View;
 use Laravel\Passport\Passport;
 use Log;
@@ -206,7 +205,7 @@ class InstallController extends Controller
             return false;
         }
         // clear cache as well.
-        Cache::clear();
+        Cache::clear(); // @phpstan-ignore-line
         Preferences::mark();
 
         return true;
diff --git a/app/Models/TransactionJournal.php b/app/Models/TransactionJournal.php
index c6aa1de879..0b63f2e1df 100644
--- a/app/Models/TransactionJournal.php
+++ b/app/Models/TransactionJournal.php
@@ -56,6 +56,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
  * @property \Carbon\Carbon|null                                                                       $process_date
  * @property int                                                                                       $order
  * @property int                                                                                       $tag_count
+ * @property string                                                                                    $transaction_type_type
  * @property bool                                                                                      $encrypted
  * @property bool                                                                                      $completed
  * @property-read \Illuminate\Database\Eloquent\Collection|\FireflyIII\Models\Attachment[]             $attachments