Code cleanup.

This commit is contained in:
James Cole
2021-03-28 11:39:26 +02:00
parent 6401b5c9eb
commit 5abbb8a807
155 changed files with 651 additions and 499 deletions

View File

@@ -19,8 +19,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
declare(strict_types=1);
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Events\DestroyedTransactionGroup;
@@ -37,7 +38,6 @@ class DestroyController extends Controller
{
private JournalRepositoryInterface $repository;
/**
* TransactionController constructor.
*
@@ -59,7 +59,6 @@ class DestroyController extends Controller
);
}
/**
* Remove the specified resource from storage.
*
@@ -77,7 +76,6 @@ class DestroyController extends Controller
return response()->json([], 204);
}
/**
* Remove the specified resource from storage.
*
@@ -92,4 +90,4 @@ class DestroyController extends Controller
return response()->json([], 204);
}
}
}

View File

@@ -19,8 +19,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
declare(strict_types=1);
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Models\TransactionGroup;
@@ -64,7 +65,6 @@ class ListController extends Controller
);
}
/**
* @param TransactionGroup $transactionGroup
*
@@ -97,7 +97,6 @@ class ListController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
/**
* @param TransactionGroup $transactionGroup
*
@@ -114,8 +113,6 @@ class ListController extends Controller
}
$count = $collection->count();
$events = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
// make paginator:
$paginator = new LengthAwarePaginator($events, $count, $pageSize, $this->parameters->get('page'));
$paginator->setPath(route('api.v1.transactions.piggy_bank_events', [$transactionGroup->id]) . $this->buildParams());
@@ -126,8 +123,6 @@ class ListController extends Controller
$resource = new FractalCollection($events, $transformer, 'piggy_bank_events');
$resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
// /** @var PiggyBankEventTransformer $transformer */
// $transformer = app(PiggyBankEventTransformer::class);
// $transformer->setParameters($this->parameters);
@@ -137,7 +132,6 @@ class ListController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
/**
* @param TransactionJournal $transactionJournal
*
@@ -165,4 +159,4 @@ class ListController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
}
}

View File

@@ -19,8 +19,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
declare(strict_types=1);
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Helpers\Collector\GroupCollectorInterface;
@@ -75,8 +76,6 @@ class ShowController extends Controller
->setPage($this->parameters->get('page'))
// set types of transactions to return.
->setTypes($types);
if (null !== $this->parameters->get('start') && null !== $this->parameters->get('end')) {
$collector->setRange($this->parameters->get('start'), $this->parameters->get('end'));
}
@@ -142,4 +141,4 @@ class ShowController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
}
}

View File

@@ -19,8 +19,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
declare(strict_types=1);
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Api\V1\Requests\Models\Transaction\StoreRequest;
@@ -48,7 +49,6 @@ class StoreController extends Controller
private TransactionGroupRepositoryInterface $groupRepository;
/**
* TransactionController constructor.
*
@@ -70,7 +70,6 @@ class StoreController extends Controller
);
}
/**
* Store a new transaction.
*
@@ -130,4 +129,4 @@ class StoreController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
}
}

View File

@@ -19,8 +19,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
declare(strict_types=1);
namespace FireflyIII\Api\V1\Controllers\Models\Transaction;
use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Api\V1\Requests\Models\Transaction\UpdateRequest;
@@ -63,7 +64,6 @@ class UpdateController extends Controller
);
}
/**
* Update a transaction.
*
@@ -106,4 +106,4 @@ class UpdateController extends Controller
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
}
}
}