kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-05-05 05:33:36 +00:00
Code Issues Projects Releases Wiki Activity

Code consistency and new tests.

Browse Source
This commit is contained in:
James Cole
2018-05-12 15:50:01 +02:00
parent a47da92d81
commit 5bf520b6ed
35 changed files with 1262 additions and 1157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Support/Import/Routine/File/CSVProcessor.php
View File

@@ -80,11 +80,11 @@ class CSVProcessor implements FileProcessorInterface
}
/**
* @param ImportJob $job
* @param ImportJob $importJob
*/
public function setImportJob(ImportJob $job): void
public function setImportJob(ImportJob $importJob): void
{
Log::debug('Now in setJob()');
$this->importJob = $job;
Log::debug('Now in setImportJob()');
$this->importJob = $importJob;
}
}

4
app/Support/Import/Routine/File/FileProcessorInterface.php
View File

@@ -43,7 +43,7 @@ interface FileProcessorInterface
/**
* Set values.
*
* @param ImportJob $job
* @param ImportJob $importJob
*/
public function setImportJob(ImportJob $job): void;
public function setImportJob(ImportJob $importJob): void;
}

24
app/Support/Import/Routine/File/ImportableConverter.php
View File

@@ -31,6 +31,7 @@ use FireflyIII\Models\ImportJob;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use FireflyIII\Support\Import\Placeholder\ImportTransaction;
use InvalidArgumentException;
use Log;
/**
@@ -112,6 +113,8 @@ class ImportableConverter
}
/**
* @codeCoverageIgnore
*
* @param array $mappedValues
*/
public function setMappedValues(array $mappedValues): void
@@ -179,18 +182,27 @@ class ImportableConverter
Log::debug('Destination is an expense account. This is a withdrawal.');
$transactionType = 'withdrawal';
}
if ($transactionType === 'unknown') {
Log::error(
if ($destination->id === $source->id) {
throw new FireflyException(
sprintf(
'Cannot determine transaction type. Source account is a %s, destination is a %s',
$source->accountType->type, $destination->accountType->type
), ['source' => $source->toArray(), 'dest' => $destination->toArray()]
'Source ("%s", #%d) and destination ("%s", #%d) are the same account.', $source->name, $source->id, $destination->name, $destination->id
)
);
}
if ($transactionType === 'unknown') {
$message = sprintf(
'Cannot determine transaction type. Source account is a %s, destination is a %s', $source->accountType->type, $destination->accountType->type
);
Log::error($message, ['source' => $source->toArray(), 'dest' => $destination->toArray()]);
throw new FireflyException($message);
}
// throw error when both are he same
try {
$date = Carbon::createFromFormat($this->config['date-format'] ?? 'Ymd', $importable->date);
} catch (InvalidDateException $e) {
} catch (InvalidDateException|InvalidArgumentException $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$date = new Carbon;

1
app/Support/Import/Routine/File/MappingConverger.php
View File

@@ -82,6 +82,7 @@ class MappingConverger
}
/**
* @codeCoverageIgnore
* @return array
*/
public function getMappedValues(): array