kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-05-03 20:56:21 +00:00
Code Issues Projects Releases Wiki Activity

Add some method annotators, see if this helps with Scrutinizer issues.

Browse Source
This commit is contained in:
James Cole
2018-07-14 23:04:05 +02:00
parent c424bb097d
commit 5dad569d62
9 changed files with 38 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/Support/Preferences.php
View File

@@ -79,12 +79,12 @@ class Preferences
}
/**
* @param $name
* @param null $default
* @param string $name
* @param null $default
*
* @return \FireflyIII\Models\Preference|null
*/
public function get($name, $default = null)
public function get(string $name, $default = null): ?Preference
{
/** @var User $user */
$user = auth()->user();
@@ -125,7 +125,7 @@ class Preferences
*
* @return \FireflyIII\Models\Preference|null
*/
public function getForUser(User $user, $name, $default = null): ?Preference
public function getForUser(User $user, string $name, $default = null): ?Preference
{
$fullName = sprintf('preference%s%s', $user->id, $name);
if (Cache::has($fullName)) {
@@ -177,23 +177,21 @@ class Preferences
}
/**
* @return bool
*
*/
public function mark(): bool
public function mark(): void
{
$this->set('lastActivity', microtime());
Session::forget('first');
return true;
}
/**
* @param $name
* @param $value
* @param string $name
* @param mixed $value
*
* @return Preference
* @return \FireflyIII\Models\Preference
*/
public function set($name, $value): Preference
public function set(string $name, $value): Preference
{
$user = auth()->user();
if (null === $user) {
@@ -210,12 +208,12 @@ class Preferences
/**
* @param \FireflyIII\User $user
* @param $name
* @param string $name
* @param mixed $value
*
* @return Preference
*/
public function setForUser(User $user, $name, $value): Preference
public function setForUser(User $user, string $name, $value): Preference
{
$fullName = sprintf('preference%s%s', $user->id, $name);
Cache::forget($fullName);