kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-07 10:28:22 +00:00
Code Issues Projects Releases Wiki Activity

Fix tag bug. (again)

Browse Source
This commit is contained in:
James Cole
2015-06-08 18:51:45 +02:00
parent 77989e2720
commit 5fa87e18db
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Repositories/Tag/TagRepository.php
View File

@@ -320,13 +320,18 @@ class TagRepository implements TagRepositoryInterface
$match = true; $match = true;
/** @var TransactionJournal $check */ /** @var TransactionJournal $check */
foreach ($tag->transactionjournals as $check) { foreach ($tag->transactionjournals as $check) {
if ($check->source_account->id != $journal->source_account->id) { // $checkAccount is the source_account for a withdrawal
// $checkAccount is the destination_account for a deposit
if ($check->transactionType->type == 'Withdrawal' && $check->source_account->id != $journal->destination_account->id) {
$match = false; $match = false;
} }
if ($check->transactionType->type == 'Deposit' && $check->destination_account->id != $journal->destination_account->id) {
$match = false;
}
} }
if ($match) { if ($match) {
$journal->tags()->save($tag); $journal->tags()->save($tag);
return true; return true;
} }