kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-12 09:52:20 +00:00
Code Issues Projects Releases Wiki Activity

Fix old todo item

Browse Source
This commit is contained in:
James Cole
2020-01-07 17:18:56 +01:00
parent d116609389
commit 6019638388
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php
View File

@@ -125,19 +125,17 @@ class OtherCurrenciesCorrections extends Command
if (isset($this->accountCurrencies[$accountId]) && $this->accountCurrencies[$accountId] instanceof TransactionCurrency) { if (isset($this->accountCurrencies[$accountId]) && $this->accountCurrencies[$accountId] instanceof TransactionCurrency) {
return $this->accountCurrencies[$accountId]; // @codeCoverageIgnore return $this->accountCurrencies[$accountId]; // @codeCoverageIgnore
} }
// TODO we can use getAccountCurrency() instead $currency = $this->accountRepos->getAccountCurrency($account);
$currencyId = (int)$this->accountRepos->getMetaValue($account, 'currency_id'); if (null === $currency) {
$result = $this->currencyRepos->findNull($currencyId);
if (null === $result) {
// @codeCoverageIgnoreStart // @codeCoverageIgnoreStart
$this->accountCurrencies[$accountId] = 0; $this->accountCurrencies[$accountId] = 0;
return null; return null;
// @codeCoverageIgnoreEnd // @codeCoverageIgnoreEnd
} }
$this->accountCurrencies[$accountId] = $result; $this->accountCurrencies[$accountId] = $currency;
return $result; return $currency;
} }