diff --git a/app/Api/V1/Requests/ConfigurationRequest.php b/app/Api/V1/Requests/ConfigurationRequest.php index 7a601ed6a5..93f68c2598 100644 --- a/app/Api/V1/Requests/ConfigurationRequest.php +++ b/app/Api/V1/Requests/ConfigurationRequest.php @@ -56,6 +56,8 @@ class ConfigurationRequest extends FormRequest { $name = $this->route()->parameter('configName'); switch ($name) { + default: + break; case 'is_demo_site': case 'single_user_mode': return ['value' => $this->boolean('value')]; @@ -75,6 +77,8 @@ class ConfigurationRequest extends FormRequest { $name = $this->route()->parameter('configName'); switch ($name) { + default: + break; case 'is_demo_site': case 'single_user_mode': return ['value' => ['required', new IsBoolean]]; diff --git a/app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php b/app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php index cefd9bca1b..c72b014e06 100644 --- a/app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php +++ b/app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php @@ -128,6 +128,8 @@ class OtherCurrenciesCorrections extends Command /** @var Transaction $lead */ $lead = null; switch ($journal->transactionType->type) { + default: + break; case TransactionType::WITHDRAWAL: $lead = $journal->transactions()->where('amount', '<', 0)->first(); break; diff --git a/app/Http/Controllers/Chart/AccountController.php b/app/Http/Controllers/Chart/AccountController.php index ea508d1cba..997a2c26c9 100644 --- a/app/Http/Controllers/Chart/AccountController.php +++ b/app/Http/Controllers/Chart/AccountController.php @@ -587,6 +587,8 @@ class AccountController extends Controller $entries = []; $current = clone $start; switch ($step) { + default: + break; case '1D': // per day the entire period, balance for every day. $format = (string) trans('config.month_and_day', [], $locale); diff --git a/app/Http/Controllers/Json/RecurrenceController.php b/app/Http/Controllers/Json/RecurrenceController.php index a747aa04ed..cbf6aff8da 100644 --- a/app/Http/Controllers/Json/RecurrenceController.php +++ b/app/Http/Controllers/Json/RecurrenceController.php @@ -103,8 +103,8 @@ class RecurrenceController extends Controller $repetition->repetition_skip = (int) $request->get('skip'); $repetition->weekend = (int) $request->get('weekend'); $actualEnd = clone $end; - $occurrences = []; switch ($endsAt) { + default: case 'forever': // simply generate up until $end. No change from default behavior. $occurrences = $this->recurring->getOccurrencesInRange($repetition, $actualStart, $actualEnd); diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index 44f9f70f8d..a56d4bb6b6 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -384,12 +384,13 @@ class ReportController extends Controller } switch ($reportType) { - case 'category': - $uri = route('reports.report.category', [$accounts, $categories, $start, $end]); - break; + default: case 'default': $uri = route('reports.report.default', [$accounts, $start, $end]); break; + case 'category': + $uri = route('reports.report.category', [$accounts, $categories, $start, $end]); + break; case 'audit': $uri = route('reports.report.audit', [$accounts, $start, $end]); break; diff --git a/app/Support/Search/AccountSearch.php b/app/Support/Search/AccountSearch.php index 6f6cb5e833..a8a81d7cc3 100644 --- a/app/Support/Search/AccountSearch.php +++ b/app/Support/Search/AccountSearch.php @@ -73,6 +73,7 @@ class AccountSearch implements GenericSearchInterface $like = sprintf('%%%s%%', $this->query); $originalQuery = $this->query; switch ($this->field) { + default: case self::SEARCH_ALL: $query->where( static function (Builder $q) use ($like) { diff --git a/app/Validation/TransactionValidation.php b/app/Validation/TransactionValidation.php index 457bf4fa3e..f60ce56f7b 100644 --- a/app/Validation/TransactionValidation.php +++ b/app/Validation/TransactionValidation.php @@ -354,6 +354,7 @@ trait TransactionValidation $sources = array_unique($sources); $dests = array_unique($dests); switch ($type) { + default: case 'withdrawal': if (count($sources) > 1) { $validator->errors()->add('transactions.0.source_id', (string)trans('validation.all_accounts_equal')); @@ -409,6 +410,7 @@ trait TransactionValidation } // TODO not the best way to loop this. switch ($type) { + default: case 'withdrawal': if ($this->arrayEqual($comparison['source_id'])) { // source ID's are equal, return void.