kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-12 09:52:20 +00:00
Code Issues Projects Releases Wiki Activity

Fix code quality with rector [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-11-09 09:08:03 +01:00
parent d2610be790
commit 68183a0a0e
209 changed files with 1021 additions and 1248 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
app/Validation/TransactionValidation.php
View File

@@ -24,6 +24,7 @@ declare(strict_types=1);
namespace FireflyIII\Validation;
use Illuminate\Contracts\Validation\Validator;
use FireflyIII\Enums\AccountTypeEnum;
use FireflyIII\Enums\TransactionTypeEnum;
use FireflyIII\Exceptions\FireflyException;
@@ -36,7 +37,6 @@ use FireflyIII\Repositories\Account\AccountRepository;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\User;
use Illuminate\Support\Facades\Log;
use Illuminate\Validation\Validator;
/**
* Trait TransactionValidation
@@ -302,11 +302,7 @@ trait TransactionValidation
private function isLiability(Account $account): bool
{
$type = $account->accountType->type;
if (in_array($type, config('firefly.valid_liabilities'), true)) {
return true;
}
return false;
return in_array($type, config('firefly.valid_liabilities'), true);
}
private function isAsset(Account $account): bool
@@ -327,11 +323,7 @@ trait TransactionValidation
if ('' === $transaction['foreign_amount']) {
return false;
}
if (0 === bccomp('0', (string) $transaction['foreign_amount'])) {
return false;
}
return true;
return 0 !== bccomp('0', (string) $transaction['foreign_amount']);
}
/**
@@ -758,12 +750,8 @@ trait TransactionValidation
// source ID's are equal, return void.
return true;
}
if ($this->arrayEqual($comparison['source_name'])) {
// source names are equal, return void.
return true;
}
return false;
// source names are equal, return void.
return (bool) $this->arrayEqual($comparison['source_name']);
}
private function arrayEqual(array $array): bool
@@ -777,12 +765,8 @@ trait TransactionValidation
// destination ID's are equal, return void.
return true;
}
if ($this->arrayEqual($comparison['destination_name'])) {
// destination names are equal, return void.
return true;
}
return false;
// destination names are equal, return void.
return (bool) $this->arrayEqual($comparison['destination_name']);
}
private function compareAccountDataTransfer(array $comparison): bool
@@ -799,11 +783,7 @@ trait TransactionValidation
// destination ID's are equal, return void.
return true;
}
if ($this->arrayEqual($comparison['destination_name'])) {
// destination names are equal, return void.
return true;
}
return false;
// destination names are equal, return void.
return (bool) $this->arrayEqual($comparison['destination_name']);
}
}