kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-05-04 21:23:36 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2018-07-26 06:10:17 +02:00
parent e8c9554dd6
commit 6bcfea1de4
37 changed files with 351 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/Rules/ValidTransactions.php
View File

@@ -49,7 +49,7 @@ class ValidTransactions implements Rule
*
* @return string
*/
public function message()
public function message(): string
{
return (string)trans('validation.invalid_selection');
}
@@ -61,8 +61,9 @@ class ValidTransactions implements Rule
* @param mixed $value
*
* @return bool
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function passes($attribute, $value)
public function passes($attribute, $value): bool
{
Log::debug('In ValidTransactions::passes');
if (!\is_array($value)) {
@@ -73,7 +74,7 @@ class ValidTransactions implements Rule
$count = Transaction::where('transactions.id', $transactionId)
->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id')
->where('accounts.user_id', $userId)->count();
if ($count === 0) {
if (0 === $count) {
Log::debug(sprintf('Count for transaction #%d and user #%d is zero! Return FALSE', $transactionId, $userId));
return false;