Refactor the expandedform methods. First commit to see how Scrutinizer likes this. This commit will break most views.

app/Support/Form/PiggyBankForm.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * PiggyBankForm.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Support\Form;
+
+
+use FireflyIII\Models\PiggyBank;
+use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
+
+/**
+ * Class PiggyBankForm
+ *
+ * TODO cleanup and describe.
+ */
+class PiggyBankForm
+{
+    use FormSupport;
+    /**
+     * @param string $name
+     * @param mixed $value
+     * @param array $options
+     *
+     * @return string
+     */
+    public function piggyBankList(string $name, $value = null, array $options = null): string
+    {
+
+        // make repositories
+        /** @var PiggyBankRepositoryInterface $repository */
+        $repository = app(PiggyBankRepositoryInterface::class);
+        $piggyBanks = $repository->getPiggyBanksWithAmount();
+        $array      = [
+            0 => (string)trans('firefly.none_in_select_list'),
+        ];
+        /** @var PiggyBank $piggy */
+        foreach ($piggyBanks as $piggy) {
+            $array[$piggy->id] = $piggy->name;
+        }
+
+        return $this->select($name, $array, $value, $options);
+    }
+}