Rector code cleanup

2025-12-12 01:42:32 +00:00 · 2025-05-24 16:39:20 +02:00
parent 6a82a813e0
commit 6e5a08245c
62 changed files with 172 additions and 115 deletions
--- a/app/Http/Controllers/DebugController.php
+++ b/app/Http/Controllers/DebugController.php
@@ -111,7 +111,7 @@ class DebugController extends Controller

        try {
            Artisan::call('twig:clean');
-        } catch (\Exception $e) {  // intentional generic exception
+        } catch (Exception $e) {  // intentional generic exception
            throw new FireflyException($e->getMessage(), 0, $e);
        }

@@ -203,7 +203,7 @@ class DebugController extends Controller
                $return['build'] = trim((string) file_get_contents('/var/www/counter-main.txt'));
                app('log')->debug(sprintf('build is now "%s"', $return['build']));
            }
-        } catch (\Exception $e) {
+        } catch (Exception $e) {
            app('log')->debug('Could not check build counter, but thats ok.');
            app('log')->warning($e->getMessage());
        }
@@ -212,7 +212,7 @@ class DebugController extends Controller
            if (file_exists('/var/www/build-date-main.txt')) {
                $return['build_date'] = trim((string) file_get_contents('/var/www/build-date-main.txt'));
            }
-        } catch (\Exception $e) {
+        } catch (Exception $e) {
            app('log')->debug('Could not check build date, but thats ok.');
            app('log')->warning($e->getMessage());
        }
--- a/app/Http/Controllers/HomeController.php
+++ b/app/Http/Controllers/HomeController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers;

+use Exception;
 use Carbon\Carbon;
 use Carbon\Exceptions\InvalidFormatException;
 use FireflyIII\Enums\AccountTypeEnum;
@@ -57,7 +58,7 @@ class HomeController extends Controller
    /**
     * Change index date range.
     *
-     * @throws \Exception
+     * @throws Exception
     */
    public function dateRange(Request $request): JsonResponse
    {
--- a/app/Http/Controllers/Json/FrontpageController.php
+++ b/app/Http/Controllers/Json/FrontpageController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Json;

+use Throwable;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Models\PiggyBank;
@@ -89,7 +90,7 @@ class FrontpageController extends Controller
        if (0 !== count($info)) {
            try {
                $html = view('json.piggy-banks', compact('info', 'convertToNative', 'native'))->render();
-            } catch (\Throwable $e) {
+            } catch (Throwable $e) {
                app('log')->error(sprintf('Cannot render json.piggy-banks: %s', $e->getMessage()));
                app('log')->error($e->getTraceAsString());
                $html = 'Could not render view.';
--- a/app/Http/Controllers/Json/ReconcileController.php
+++ b/app/Http/Controllers/Json/ReconcileController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Json;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Exceptions\FireflyException;
@@ -130,7 +131,7 @@ class ReconcileController extends Controller

        try {
            $view = view('accounts.reconcile.overview', compact('account', 'start', 'diffCompare', 'difference', 'end', 'clearedAmount', 'startBalance', 'endBalance', 'amount', 'route', 'countCleared', 'reconSum', 'selectedIds'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('View error: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $view = sprintf('Could not render accounts.reconcile.overview: %s', $e->getMessage());
@@ -228,7 +229,7 @@ class ReconcileController extends Controller
                'accounts.reconcile.transactions',
                compact('account', 'journals', 'currency', 'start', 'end', 'selectionStart', 'selectionEnd')
            )->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $html = sprintf('Could not render accounts.reconcile.transactions: %s', $e->getMessage());
--- a/app/Http/Controllers/Json/RuleController.php
+++ b/app/Http/Controllers/Json/RuleController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Json;

+use Throwable;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
 use Illuminate\Http\JsonResponse;
@@ -50,7 +51,7 @@ class RuleController extends Controller

        try {
            $view = view('rules.partials.action', compact('actions', 'count'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Cannot render rules.partials.action: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $view = 'Could not render view.';
@@ -80,7 +81,7 @@ class RuleController extends Controller

        try {
            $view = view('rules.partials.trigger', compact('triggers', 'count'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Cannot render rules.partials.trigger: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $view = 'Could not render view.';
--- a/app/Http/Controllers/PreferencesController.php
+++ b/app/Http/Controllers/PreferencesController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers;

+use JsonException;
 use Carbon\Carbon;
 use FireflyIII\Enums\AccountTypeEnum;
 use FireflyIII\Events\Preferences\UserGroupChangedDefaultCurrency;
@@ -155,7 +156,7 @@ class PreferencesController extends Controller

        try {
            $locales = json_decode((string) file_get_contents(resource_path(sprintf('locales/%s/locales.json', $language))), true, 512, JSON_THROW_ON_ERROR);
-        } catch (\JsonException $e) {
+        } catch (JsonException $e) {
            app('log')->error($e->getMessage());
            $locales = [];
        }
--- a/app/Http/Controllers/Profile/MfaController.php
+++ b/app/Http/Controllers/Profile/MfaController.php
@@ -24,6 +24,8 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Profile;

+use Cookie;
+use Google2FA;
 use Carbon\Carbon;
 use FireflyIII\Events\Security\DisabledMFA;
 use FireflyIII\Events\Security\EnabledMFA;
@@ -182,7 +184,7 @@ class MfaController extends Controller

        // also logout current 2FA tokens.
        $cookieName = config('google2fa.cookie_name', 'google2fa_token');
-        \Cookie::forget($cookieName);
+        Cookie::forget($cookieName);

        // send user notification.
        Log::channel('audit')->info(sprintf('User "%s" has disabled MFA', $user->email));
@@ -215,8 +217,8 @@ class MfaController extends Controller
        }

        $domain     = $this->getDomain();
-        $secret     = \Google2FA::generateSecretKey();
-        $image      = \Google2FA::getQRCodeInline($domain, auth()->user()->email, $secret);
+        $secret     = Google2FA::generateSecretKey();
+        $image      = Google2FA::getQRCodeInline($domain, auth()->user()->email, $secret);

        app('preferences')->set('temp-mfa-secret', $secret);

@@ -272,7 +274,7 @@ class MfaController extends Controller

        // make sure MFA is logged out.
        if ('testing' !== config('app.env')) {
-            \Google2FA::logout();
+            Google2FA::logout();
        }

        // drop all info from session:
--- a/app/Http/Controllers/ProfileController.php
+++ b/app/Http/Controllers/ProfileController.php
@@ -23,6 +23,9 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers;

+use Auth;
+use Hash;
+use Exception;
 use FireflyIII\Events\UserChangedEmail;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Exceptions\ValidationException;
@@ -203,7 +206,7 @@ class ProfileController extends Controller
        $existing = $repository->findByEmail($newEmail);
        if ($existing instanceof User) {
            // force user logout.
-            \Auth::guard()->logout(); // @phpstan-ignore-line (does not recognize function)
+            Auth::guard()->logout(); // @phpstan-ignore-line (does not recognize function)
            $request->session()->invalidate();

            session()->flash('success', (string) trans('firefly.email_changed'));
@@ -217,7 +220,7 @@ class ProfileController extends Controller
        event(new UserChangedEmail($user, $newEmail, $oldEmail));

        // force user logout.
-        \Auth::guard()->logout(); // @phpstan-ignore-line (does not recognize function)
+        Auth::guard()->logout(); // @phpstan-ignore-line (does not recognize function)
        $request->session()->invalidate();
        session()->flash('success', (string) trans('firefly.email_changed'));

@@ -310,7 +313,7 @@ class ProfileController extends Controller
            return redirect(route('profile.index'));
        }

-        if (!\Hash::check($request->get('password'), auth()->user()->password)) {
+        if (!Hash::check($request->get('password'), auth()->user()->password)) {
            session()->flash('error', (string) trans('firefly.invalid_password'));

            return redirect(route('profile.delete-account'));
@@ -343,8 +346,8 @@ class ProfileController extends Controller
            'email'    => auth()->user()->email,
            'password' => $request->get('password'),
        ];
-        if (\Auth::once($creds)) {
-            \Auth::logoutOtherDevices($request->get('password'));
+        if (Auth::once($creds)) {
+            Auth::logoutOtherDevices($request->get('password'));
            session()->flash('info', (string) trans('firefly.other_sessions_logged_out'));

            return redirect(route('profile.index'));
@@ -359,7 +362,7 @@ class ProfileController extends Controller
     *
     * @return Redirector|RedirectResponse
     *
-     * @throws \Exception
+     * @throws Exception
     */
    public function regenerate(Request $request)
    {
--- a/app/Http/Controllers/Report/AccountController.php
+++ b/app/Http/Controllers/Report/AccountController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -58,7 +59,7 @@ class AccountController extends Controller

        try {
            $result = view('reports.partials.accounts', compact('accountReport'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.accounts: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
--- a/app/Http/Controllers/Report/BalanceController.php
+++ b/app/Http/Controllers/Report/BalanceController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Exceptions\FireflyException;
@@ -140,7 +141,7 @@ class BalanceController extends Controller

        try {
            $result = view('reports.partials.balance', compact('report'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.balance: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
--- a/app/Http/Controllers/Report/BillController.php
+++ b/app/Http/Controllers/Report/BillController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Report\ReportHelperInterface;
@@ -58,7 +59,7 @@ class BillController extends Controller

        try {
            $result = view('reports.partials.bills', compact('report'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budgets: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
--- a/app/Http/Controllers/Report/BudgetController.php
+++ b/app/Http/Controllers/Report/BudgetController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -176,7 +177,7 @@ class BudgetController extends Controller

        try {
            $result = view('reports.budget.partials.avg-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());
            app('log')->error($e->getTraceAsString());
@@ -326,7 +327,7 @@ class BudgetController extends Controller

        try {
            $result = view('reports.partials.budget-period', compact('report', 'periods'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
@@ -377,7 +378,7 @@ class BudgetController extends Controller

        try {
            $result = view('reports.budget.partials.top-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

--- a/app/Http/Controllers/Report/CategoryController.php
+++ b/app/Http/Controllers/Report/CategoryController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -295,7 +296,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.category.partials.avg-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -345,7 +346,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.category.partials.avg-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -527,7 +528,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.partials.category-period', compact('report', 'periods'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render category::expenses: %s', $e->getMessage()));
            $result = sprintf('An error prevented Firefly III from rendering: %s. Apologies.', $e->getMessage());

@@ -599,7 +600,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.partials.category-period', compact('report', 'periods'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render category::expenses: %s', $e->getMessage()));
            $result = sprintf('An error prevented Firefly III from rendering: %s. Apologies.', $e->getMessage());

@@ -639,7 +640,7 @@ class CategoryController extends Controller
        try {
            $result = view('reports.partials.categories', compact('report'))->render();
            $cache->store($result);
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render category::expenses: %s', $e->getMessage()));
            $result = sprintf('An error prevented Firefly III from rendering: %s. Apologies.', $e->getMessage());

@@ -687,7 +688,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.category.partials.top-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -735,7 +736,7 @@ class CategoryController extends Controller

        try {
            $result = view('reports.category.partials.top-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

--- a/app/Http/Controllers/Report/DoubleController.php
+++ b/app/Http/Controllers/Report/DoubleController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -102,7 +103,7 @@ class DoubleController extends Controller

        try {
            $result = view('reports.double.partials.avg-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -152,7 +153,7 @@ class DoubleController extends Controller

        try {
            $result = view('reports.double.partials.avg-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -429,7 +430,7 @@ class DoubleController extends Controller

        try {
            $result = view('reports.double.partials.top-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -477,7 +478,7 @@ class DoubleController extends Controller

        try {
            $result = view('reports.double.partials.top-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

--- a/app/Http/Controllers/Report/OperationsController.php
+++ b/app/Http/Controllers/Report/OperationsController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -78,7 +79,7 @@ class OperationsController extends Controller

        try {
            $result = view('reports.partials.income-expenses', compact('report', 'type'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.income-expense: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
@@ -112,7 +113,7 @@ class OperationsController extends Controller

        try {
            $result = view('reports.partials.income-expenses', compact('report', 'type'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.income-expenses: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
@@ -167,7 +168,7 @@ class OperationsController extends Controller

        try {
            $result = view('reports.partials.operations', compact('sums'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Could not render reports.partials.operations: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $result = 'Could not render view.';
--- a/app/Http/Controllers/Report/TagController.php
+++ b/app/Http/Controllers/Report/TagController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Report;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -292,7 +293,7 @@ class TagController extends Controller

        try {
            $result = view('reports.tag.partials.avg-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -342,7 +343,7 @@ class TagController extends Controller

        try {
            $result = view('reports.tag.partials.avg-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -490,7 +491,7 @@ class TagController extends Controller

        try {
            $result = view('reports.tag.partials.top-expenses', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

@@ -538,7 +539,7 @@ class TagController extends Controller

        try {
            $result = view('reports.tag.partials.top-income', compact('result'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->debug(sprintf('Could not render reports.partials.budget-period: %s', $e->getMessage()));
            $result = sprintf('Could not render view: %s', $e->getMessage());

--- a/app/Http/Controllers/Rule/EditController.php
+++ b/app/Http/Controllers/Rule/EditController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Rule;

+use Throwable;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Http\Requests\RuleFormRequest;
@@ -177,7 +178,7 @@ class EditController extends Controller
                        'triggers'   => $triggers,
                    ]
                )->render();
-            } catch (\Throwable $e) {
+            } catch (Throwable $e) {
                $message = sprintf('Throwable was thrown in getPreviousTriggers(): %s', $e->getMessage());
                app('log')->debug($message);
                app('log')->error($e->getTraceAsString());
--- a/app/Http/Controllers/Rule/SelectController.php
+++ b/app/Http/Controllers/Rule/SelectController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Rule;

+use Throwable;
 use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
@@ -174,7 +175,7 @@ class SelectController extends Controller

        try {
            $view = view('list.journals-array-tiny', ['groups' => $collection])->render();
-        } catch (\Throwable $exception) {
+        } catch (Throwable $exception) {
            app('log')->error(sprintf('Could not render view in testTriggers(): %s', $exception->getMessage()));
            app('log')->error($exception->getTraceAsString());
            $view = sprintf('Could not render list.journals-tiny: %s', $exception->getMessage());
@@ -216,7 +217,7 @@ class SelectController extends Controller

        try {
            $view = view('list.journals-array-tiny', ['groups' => $collection])->render();
-        } catch (\Throwable $exception) {
+        } catch (Throwable $exception) {
            $message = sprintf('Could not render view in testTriggersByRule(): %s', $exception->getMessage());
            app('log')->error($message);
            app('log')->error($exception->getTraceAsString());
--- a/app/Http/Controllers/RuleGroup/ExecutionController.php
+++ b/app/Http/Controllers/RuleGroup/ExecutionController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\RuleGroup;

+use Exception;
 use Carbon\Carbon;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Http\Requests\SelectTransactionsRequest;
@@ -64,7 +65,7 @@ class ExecutionController extends Controller
    /**
     * Execute the given rulegroup on a set of existing transactions.
     *
-     * @throws \Exception
+     * @throws Exception
     */
    public function execute(SelectTransactionsRequest $request, RuleGroup $ruleGroup): RedirectResponse
    {
--- a/app/Http/Controllers/SearchController.php
+++ b/app/Http/Controllers/SearchController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers;

+use Throwable;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
 use FireflyIII\Support\Search\SearchInterface;
@@ -118,7 +119,7 @@ class SearchController extends Controller

        try {
            $html = view('search.search', compact('groups', 'hasPages', 'searchTime'))->render();
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
            app('log')->error(sprintf('Cannot render search.search: %s', $e->getMessage()));
            app('log')->error($e->getTraceAsString());
            $html = 'Could not render view.';
--- a/app/Http/Controllers/System/InstallController.php
+++ b/app/Http/Controllers/System/InstallController.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\System;

+use Artisan;
 use Cache;
 use Exception;
 use FireflyIII\Exceptions\FireflyException;
@@ -142,14 +143,14 @@ class InstallController extends Controller
                $this->keys();
            }
            if ('generate-keys' !== $command) {
-                \Artisan::call($command, $args);
-                app('log')->debug(\Artisan::output());
+                Artisan::call($command, $args);
+                app('log')->debug(Artisan::output());
            }
-        } catch (\Exception $e) { // intentional generic exception
+        } catch (Exception $e) { // intentional generic exception
            throw new FireflyException($e->getMessage(), 0, $e);
        }
        // clear cache as well.
-        \Cache::clear();
+        Cache::clear();
        app('preferences')->mark();

        return true;
--- a/app/Http/Controllers/Transaction/ConvertController.php
+++ b/app/Http/Controllers/Transaction/ConvertController.php
@@ -82,7 +82,7 @@ class ConvertController extends Controller
     *
     * @return Factory|Redirector|RedirectResponse|View
     *
-     * @throws \Exception
+     * @throws Exception
     */
    public function index(TransactionType $destinationType, TransactionGroup $group)
    {
@@ -214,7 +214,7 @@ class ConvertController extends Controller
    }

    /**
-     * @throws \Exception
+     * @throws Exception
     */
    private function getLiabilities(): array
    {
@@ -238,7 +238,7 @@ class ConvertController extends Controller
    }

    /**
-     * @throws \Exception
+     * @throws Exception
     */
    private function getAssetAccounts(): array
    {
--- a/app/Http/Controllers/Transaction/MassController.php
+++ b/app/Http/Controllers/Transaction/MassController.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Transaction;

+use InvalidArgumentException;
 use Carbon\Carbon;
 use FireflyIII\Enums\AccountTypeEnum;
 use FireflyIII\Enums\TransactionTypeEnum;
@@ -231,7 +232,7 @@ class MassController extends Controller

        try {
            $carbon = Carbon::parse($value[$journalId]);
-        } catch (\InvalidArgumentException $e) {
+        } catch (InvalidArgumentException $e) {
            Log::warning(sprintf('Could not parse "%s" but dont mind', $value[$journalId]));
            Log::warning($e->getMessage());

--- a/app/Http/Middleware/Authenticate.php
+++ b/app/Http/Middleware/Authenticate.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\User;
 use Illuminate\Auth\AuthenticationException;
@@ -56,7 +57,7 @@ class Authenticate
     * @throws FireflyException
     * @throws AuthenticationException
     */
-    public function handle($request, \Closure $next, ...$guards)
+    public function handle($request, Closure $next, ...$guards)
    {
        $this->authenticate($request, $guards);

--- a/app/Http/Middleware/Binder.php
+++ b/app/Http/Middleware/Binder.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Support\Domain;
 use Illuminate\Contracts\Auth\Factory as Auth;
 use Illuminate\Http\Request;
@@ -63,7 +64,7 @@ class Binder
     *
     * @return mixed
     */
-    public function handle($request, \Closure $next)
+    public function handle($request, Closure $next)
    {
        foreach ($request->route()->parameters() as $key => $value) {
            if (array_key_exists($key, $this->binders)) {
--- a/app/Http/Middleware/InstallationId.php
+++ b/app/Http/Middleware/InstallationId.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Support\System\GeneratesInstallationId;
 use Illuminate\Http\Request;

@@ -41,7 +42,7 @@ class InstallationId
     *
     * @return mixed
     */
-    public function handle($request, \Closure $next)
+    public function handle($request, Closure $next)
    {
        $this->generateInstallationId();

--- a/app/Http/Middleware/Installer.php
+++ b/app/Http/Middleware/Installer.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Support\System\OAuthKeys;
 use Illuminate\Database\QueryException;
@@ -45,7 +46,7 @@ class Installer
     *
     * @throws FireflyException
     */
-    public function handle($request, \Closure $next)
+    public function handle($request, Closure $next)
    {
        // Log::debug(sprintf('Installer middleware for URL %s', $request->url()));
        // ignore installer in test environment.
--- a/app/Http/Middleware/InterestingMessage.php
+++ b/app/Http/Middleware/InterestingMessage.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Models\Account;
 use FireflyIII\Models\Bill;
 use FireflyIII\Models\GroupMembership;
@@ -45,7 +46,7 @@ class InterestingMessage
     *
     * @return mixed
     */
-    public function handle(Request $request, \Closure $next)
+    public function handle(Request $request, Closure $next)
    {
        if ($this->testing()) {
            return $next($request);
--- a/app/Http/Middleware/IsAdmin.php
+++ b/app/Http/Middleware/IsAdmin.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\Request;
@@ -40,7 +41,7 @@ class IsAdmin
     *
     * @return mixed
     */
-    public function handle(Request $request, \Closure $next, $guard = null)
+    public function handle(Request $request, Closure $next, $guard = null)
    {
        if (Auth::guard($guard)->guest()) {
            if ($request->ajax()) {
--- a/app/Http/Middleware/IsDemoUser.php
+++ b/app/Http/Middleware/IsDemoUser.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\Request;
@@ -37,7 +38,7 @@ class IsDemoUser
     *
     * @return mixed
     */
-    public function handle(Request $request, \Closure $next)
+    public function handle(Request $request, Closure $next)
    {
        /** @var null|User $user */
        $user       = $request->user();
--- a/app/Http/Middleware/Range.php
+++ b/app/Http/Middleware/Range.php
@@ -23,6 +23,8 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
+use App;
 use Carbon\Carbon;
 use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Support\Facades\Amount;
@@ -42,7 +44,7 @@ class Range
     *
     * @return mixed
     */
-    public function handle(Request $request, \Closure $next)
+    public function handle(Request $request, Closure $next)
    {
        if (null !== $request->user()) {
            // set start, end and finish:
@@ -101,7 +103,7 @@ class Range
        // get locale preference:
        $language          = app('steam')->getLanguage();
        $locale            = app('steam')->getLocale();
-        \App::setLocale($language);
+        App::setLocale($language);
        Carbon::setLocale(substr((string) $locale, 0, 2));

        $localeArray       = app('steam')->getLocaleArray($locale);
--- a/app/Http/Middleware/RedirectIfAuthenticated.php
+++ b/app/Http/Middleware/RedirectIfAuthenticated.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;

@@ -39,7 +40,7 @@ class RedirectIfAuthenticated
     *
     * @return mixed
     */
-    public function handle($request, \Closure $next, $guard = null)
+    public function handle($request, Closure $next, $guard = null)
    {
        if (Auth::guard($guard)->check()) {
            return response()->redirectTo(route('index'));
--- a/app/Http/Middleware/SecureHeaders.php
+++ b/app/Http/Middleware/SecureHeaders.php
@@ -24,6 +24,8 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Closure;
+use Exception;
 use Barryvdh\Debugbar\Facades\Debugbar;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Vite;
@@ -38,9 +40,9 @@ class SecureHeaders
     *
     * @return mixed
     *
-     * @throws \Exception
+     * @throws Exception
     */
-    public function handle(Request $request, \Closure $next)
+    public function handle(Request $request, Closure $next)
    {
        // generate and share nonce.
        $nonce              = base64_encode(random_bytes(16));
--- a/app/Http/Middleware/StartFireflySession.php
+++ b/app/Http/Middleware/StartFireflySession.php
@@ -23,6 +23,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Override;
 use Illuminate\Contracts\Session\Session;
 use Illuminate\Http\Request;
 use Illuminate\Session\Middleware\StartSession;
@@ -37,7 +38,7 @@ class StartFireflySession extends StartSession
     *
     * @param Session $session
     */
-    #[\Override]
+    #[Override]
    protected function storeCurrentUrl(Request $request, $session): void
    {
        $url     = $request->fullUrl();
--- a/app/Http/Middleware/TrustHosts.php
+++ b/app/Http/Middleware/TrustHosts.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Middleware;

+use Override;
 use Illuminate\Http\Middleware\TrustHosts as Middleware;

 class TrustHosts extends Middleware
@@ -33,7 +34,7 @@ class TrustHosts extends Middleware
     *
     * @return array<int, null|string>
     */
-    #[\Override]
+    #[Override]
    public function hosts(): array
    {
        return [
--- a/app/Http/Requests/ReportFormRequest.php
+++ b/app/Http/Requests/ReportFormRequest.php
@@ -149,7 +149,7 @@ class ReportFormRequest extends FormRequest
            if (false !== $result && 0 !== $result) {
                try {
                    $date = new Carbon($parts[1]);
-                } catch (\Exception $e) { // intentional generic exception
+                } catch (Exception $e) { // intentional generic exception
                    $error = sprintf('"%s" is not a valid date range: %s', $range, $e->getMessage());
                    app('log')->error($error);
                    app('log')->error($e->getTraceAsString());
@@ -187,7 +187,7 @@ class ReportFormRequest extends FormRequest
            if (false !== $result && 0 !== $result) {
                try {
                    $date = new Carbon($parts[0]);
-                } catch (\Exception $e) { // intentional generic exception
+                } catch (Exception $e) { // intentional generic exception
                    $error = sprintf('"%s" is not a valid date range: %s', $range, $e->getMessage());
                    app('log')->error($error);
                    app('log')->error($e->getTraceAsString());