mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2026-01-03 12:04:28 +00:00
Remove TODO's.
This commit is contained in:
@@ -73,7 +73,7 @@ trait ChartGeneration
|
||||
$chartData = [];
|
||||
/** @var Account $account */
|
||||
foreach ($accounts as $account) {
|
||||
// TODO we can use getAccountCurrency() instead
|
||||
// See reference nr. 33
|
||||
$currency = $repository->findNull((int)$accountRepos->getMetaValue($account, 'currency_id'));
|
||||
if (null === $currency) {
|
||||
$currency = $default;
|
||||
|
||||
@@ -115,7 +115,7 @@ trait ModelInformation
|
||||
*/
|
||||
protected function getTriggersForBill(Bill $bill): array // get info and augument
|
||||
{
|
||||
// TODO duplicated code.
|
||||
// See reference nr. 39
|
||||
$operators = config('firefly.search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
@@ -167,7 +167,7 @@ trait ModelInformation
|
||||
*/
|
||||
private function getTriggersForJournal(TransactionJournal $journal): array
|
||||
{
|
||||
// TODO duplicated code.
|
||||
// See reference nr. 40
|
||||
$operators = config('firefly.search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
|
||||
@@ -38,7 +38,7 @@ use Log;
|
||||
/**
|
||||
* Trait PeriodOverview.
|
||||
*
|
||||
* TODO verify this all works as expected.
|
||||
* See reference nr. 36
|
||||
*
|
||||
* - Always request start date and end date.
|
||||
* - Group expenses, income, etc. under this period.
|
||||
@@ -392,7 +392,7 @@ trait PeriodOverview
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO fix date.
|
||||
* See reference nr. 37
|
||||
*
|
||||
* Show period overview for no category view.
|
||||
*
|
||||
|
||||
@@ -292,7 +292,7 @@ trait RenderPartialViews
|
||||
*/
|
||||
protected function getCurrentTriggers(Rule $rule): array // get info from object and present.
|
||||
{
|
||||
// TODO duplicated code.
|
||||
// See reference nr. 38
|
||||
$operators = config('firefly.search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
|
||||
@@ -79,7 +79,7 @@ trait RuleManagement
|
||||
*/
|
||||
protected function getPreviousTriggers(Request $request): array
|
||||
{
|
||||
// TODO duplicated code.
|
||||
// See reference nr. 34
|
||||
$operators = config('firefly.search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
@@ -124,7 +124,7 @@ trait RuleManagement
|
||||
*/
|
||||
protected function parseFromOperators(array $submittedOperators): array
|
||||
{
|
||||
// TODO duplicated code.
|
||||
// See reference nr. 35
|
||||
$operators = config('firefly.search.operators');
|
||||
$renderedEntries = [];
|
||||
$triggers = [];
|
||||
|
||||
Reference in New Issue
Block a user