kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-05-04 13:16:31 +00:00
Code Issues Projects Releases Wiki Activity

Fix moar phpstan issues.

Browse Source
This commit is contained in:
James Cole
2026-03-08 17:44:19 +01:00
parent 84ea19d14c
commit 91b7ee06d8
13 changed files with 139 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/TransactionRules/Actions/ConvertToTransfer.php
View File

@@ -299,13 +299,18 @@ class ConvertToTransfer implements ActionInterface
*/
private function getDestinationAccount(TransactionJournal $journal): Account
{
/** @var null|Transaction $destAccount */
$destAccount = $journal->transactions()->where('amount', '>', 0)->first();
if (null === $destAccount) {
/** @var null|Transaction $destTransaction */
$destTransaction = $journal->transactions()->where('amount', '>', 0)->first();
if (null === $destTransaction) {
throw new FireflyException(sprintf('Cannot find destination transaction for journal #%d', $journal->id));
}
return $destAccount->account;
/** @var Account|null $res */
$res = $destTransaction->account;
if(null === $res) {
throw new FireflyException('Account is unexpectedly NULL.');
}
return $res;
}
private function getDestinationType(int $journalId): string
@@ -332,7 +337,12 @@ class ConvertToTransfer implements ActionInterface
throw new FireflyException(sprintf('Cannot find source transaction for journal #%d', $journal->id));
}
return $sourceTransaction->account;
/** @var Account|null $res */
$res = $sourceTransaction->account;
if(null === $res) {
throw new FireflyException('Account is unexpectedly NULL.');
}
return $res;
}
private function getSourceType(int $journalId): string