From 95d72d065b3ec659fe53f99223e1b1c4e1c6f63b Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 9 Apr 2021 16:02:50 +0200 Subject: [PATCH] Fix #4628 --- app/Helpers/Collector/GroupCollector.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/Helpers/Collector/GroupCollector.php b/app/Helpers/Collector/GroupCollector.php index b6ef342f54..7f8ed23b72 100644 --- a/app/Helpers/Collector/GroupCollector.php +++ b/app/Helpers/Collector/GroupCollector.php @@ -338,7 +338,7 @@ class GroupCollector implements GroupCollectorInterface */ public function setJournalIds(array $journalIds): GroupCollectorInterface { - if (0!==count($journalIds)) { + if (0 !== count($journalIds)) { $this->query->whereIn('transaction_journals.id', $journalIds); } @@ -718,10 +718,12 @@ class GroupCollector implements GroupCollectorInterface // also merge attachments: if (array_key_exists('attachment_id', $result)) { - $attachmentId = (int)$augumentedJournal['attachment_id']; - $result['attachments'][$attachmentId] = [ - 'id' => $attachmentId, - ]; + $attachmentId = (int)$augumentedJournal['attachment_id']; + if (0 !== $attachmentId) { + $result['attachments'][$attachmentId] = [ + 'id' => $attachmentId, + ]; + } } return $result;