kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-06 14:12:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-07-31 16:53:09 +02:00
parent 5524941c90
commit 9b574ce7ad
155 changed files with 1890 additions and 2263 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Support/Import/Information/GetSpectreCustomerTrait.php
View File

@@ -32,7 +32,7 @@ use Log;
/**
* Trait GetSpectreCustomerTrait
*
* @codeCoverageIgnore
*/
trait GetSpectreCustomerTrait
{

2
app/Support/Import/Information/GetSpectreTokenTrait.php
View File

@@ -31,7 +31,7 @@ use Log;
/**
* Trait GetSpectreTokenTrait
*
* @codeCoverageIgnore
*/
trait GetSpectreTokenTrait
{

2
app/Support/Import/JobConfiguration/Bunq/ChooseAccountsHandler.php
View File

@@ -119,7 +119,7 @@ class ChooseAccountsHandler implements BunqJobConfigurationInterface
Log::debug(sprintf('IBAN for bunq account #%d is "%s"', $bunqId, $bunqIban));
if (null !== $bunqIban) {
$ibanToAsset[$bunqIban] = $accountId;
$ibanToAsset[$bunqIban] = $accountId; // @codeCoverageIgnore
}
$final[$bunqId] = $accountId;
}

2
app/Support/Import/JobConfiguration/File/ConfigureMappingHandler.php
View File

@@ -312,7 +312,7 @@ class ConfigureMappingHandler implements FileConfigurationInterface
asort($columnConfig[$columnIndex]['values']);
// if the count of this array is zero, there is nothing to map.
if (0 === count($columnConfig[$columnIndex]['values'])) {
unset($columnConfig[$columnIndex]);
unset($columnConfig[$columnIndex]); // @codeCoverageIgnore
}
}

2
app/Support/Import/JobConfiguration/FinTS/ChooseAccountHandler.php
View File

@@ -34,8 +34,8 @@ use FireflyIII\Support\FinTS\FinTS;
use Illuminate\Support\MessageBag;
/**
*
* Class ChooseAccountHandler
* @codeCoverageIgnore
*/
class ChooseAccountHandler implements FinTSConfigurationInterface
{

3
app/Support/Import/JobConfiguration/FinTS/NewFinTSJobHandler.php
View File

@@ -32,8 +32,8 @@ use Illuminate\Support\Facades\Crypt;
use Illuminate\Support\MessageBag;
/**
*
* Class NewFinTSJobHandler
* @codeCoverageIgnore
*/
class NewFinTSJobHandler implements FinTSConfigurationInterface
{
@@ -62,7 +62,6 @@ class NewFinTSJobHandler implements FinTSConfigurationInterface
$this->repository->setConfiguration($this->importJob, $config);
$incomplete = false;
foreach ($config as $value) {
$incomplete = '' === $value or $incomplete;

3
app/Support/Import/Placeholder/ImportTransaction.php
View File

@@ -33,6 +33,7 @@ use Log;
/**
* Class ImportTransaction
* @codeCoverageIgnore
*/
class ImportTransaction
{
@@ -179,7 +180,7 @@ class ImportTransaction
'date-process' => 'date_process',
'date-due' => 'date_due',
];
if (in_array($role, array_keys($replaceOldRoles))) {
if (array_key_exists($role, $replaceOldRoles)) {
$role = $replaceOldRoles[$role];
}

4
app/Support/Import/Routine/File/OpposingAccountMapper.php
View File

@@ -114,9 +114,9 @@ class OpposingAccountMapper
$creation = [
'name' => $data['name'] ?? '(no name)',
'iban' => $data['iban'] ?? null,
'accountNumber' => $data['number'] ?? null,
'account_number' => $data['number'] ?? null,
'account_type_id' => null,
'account_type' => $expectedType,
'account_type' => $expectedType,
'active' => true,
'BIC' => $data['bic'] ?? null,
];