kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-04 03:43:07 +00:00
Code Issues Projects Releases Wiki Activity

Fix some PHPMD issues.

Browse Source
This commit is contained in:
James Cole
2023-11-26 16:20:24 +01:00
parent 72ead65d9c
commit a7bfdbe31f
8 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Api/V2/Controllers/Chart/CategoryController.php
View File

@@ -74,6 +74,7 @@ class CategoryController extends Controller
*
* @return JsonResponse
* @throws FireflyException
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function dashboard(DateRequest $request): JsonResponse
{

2
app/Api/V2/Controllers/Model/Account/ShowController.php
View File

@@ -40,7 +40,7 @@ class ShowController extends Controller
/**
* TODO this endpoint is not yet reachable.
*/
public function show(Request $request, Account $account): JsonResponse
public function show(Account $account): JsonResponse
{
$transformer = new AccountTransformer();
$transformer->setParameters($this->parameters);

3
app/Api/V2/Controllers/Model/Bill/IndexController.php
View File

@@ -61,13 +61,12 @@ class IndexController extends Controller
}
/**
* @param Request $request
*
* TODO see autocomplete/accountcontroller for list.
*
* @return JsonResponse
*/
public function index(Request $request): JsonResponse
public function index(): JsonResponse
{
$this->repository->correctOrder();
$bills = $this->repository->getBills();

2
app/Api/V2/Controllers/Model/Bill/ShowController.php
View File

@@ -63,7 +63,7 @@ class ShowController extends Controller
/**
* TODO this endpoint is not documented
*/
public function show(Request $request, Bill $bill): JsonResponse
public function show(Bill $bill): JsonResponse
{
$transformer = new BillTransformer();
$transformer->setParameters($this->parameters);

2
app/Api/V2/Controllers/Model/Bill/SumController.php
View File

@@ -69,6 +69,7 @@ class SumController extends Controller
* @param DateRequest $request
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function paid(DateRequest $request): JsonResponse
{
@@ -85,6 +86,7 @@ class SumController extends Controller
* TODO see autocomplete/accountcontroller for list.
*
* @param DateRequest $request
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*
* @return JsonResponse
*/

3
app/Api/V2/Controllers/Model/Budget/IndexController.php
View File

@@ -54,11 +54,10 @@ class IndexController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v2)#/budgets/listBudgets
*
* @param Request $request
*
* @return JsonResponse
*/
public function index(Request $request): JsonResponse
public function index(): JsonResponse
{
$pageSize = $this->parameters->get('limit');
$collection = $this->repository->getActiveBudgets();