Improve code quality.

This commit is contained in:
James Cole
2018-07-22 15:08:56 +02:00
parent d4ba014a8a
commit a941519db5
41 changed files with 210 additions and 52 deletions

View File

@@ -32,12 +32,14 @@ namespace FireflyIII\Import\Specifics;
*/
class AbnAmroDescription implements SpecificInterface
{
/** @var array */
/** @var array The current row. */
public $row;
/**
* @codeCoverageIgnore
* Description of this specific fix.
*
* @return string
* @codeCoverageIgnore
*/
public static function getDescription(): string
{
@@ -45,8 +47,10 @@ class AbnAmroDescription implements SpecificInterface
}
/**
* @codeCoverageIgnore
* Name of specific fix.
*
* @return string
* @codeCoverageIgnore
*/
public static function getName(): string
{
@@ -54,9 +58,13 @@ class AbnAmroDescription implements SpecificInterface
}
/**
* Run the fix.
*
* @param array $row
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function run(array $row): array
{
@@ -123,6 +131,9 @@ class AbnAmroDescription implements SpecificInterface
* Parses the current description in SEPA format.
*
* @return bool true if the description is SEPA format, false otherwise
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
protected function parseSepaDescription(): bool
{
@@ -177,6 +188,9 @@ class AbnAmroDescription implements SpecificInterface
* Parses the current description in TRTP format.
*
* @return bool true if the description is TRTP format, false otherwise
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
protected function parseTRTPDescription(): bool
{

View File

@@ -34,12 +34,14 @@ namespace FireflyIII\Import\Specifics;
*/
class IngDescription implements SpecificInterface
{
/** @var array */
/** @var array The current row. */
public $row;
/**
* @codeCoverageIgnore
* Description of the current specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getDescription(): string
{
@@ -47,8 +49,10 @@ class IngDescription implements SpecificInterface
}
/**
* @codeCoverageIgnore
* Name of the current specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getName(): string
{
@@ -56,9 +60,13 @@ class IngDescription implements SpecificInterface
}
/**
* Run the specific code.
*
* @param array $row
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function run(array $row): array
{
@@ -112,7 +120,7 @@ class IngDescription implements SpecificInterface
}
/**
*
* Copy description to name of opposite account.
*/
private function copyDescriptionToOpposite(): void
{

View File

@@ -28,8 +28,10 @@ namespace FireflyIII\Import\Specifics;
class PresidentsChoice implements SpecificInterface
{
/**
* @codeCoverageIgnore
* Description of specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getDescription(): string
{
@@ -37,8 +39,10 @@ class PresidentsChoice implements SpecificInterface
}
/**
* @codeCoverageIgnore
* Name of specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getName(): string
{
@@ -46,6 +50,8 @@ class PresidentsChoice implements SpecificInterface
}
/**
* Run this specific.
*
* @param array $row
*
* @return array

View File

@@ -26,12 +26,17 @@ use Log;
/**
* Class RabobankDescription.
*
* @codeCoverageIgnore
* @deprecated
*/
class RabobankDescription implements SpecificInterface
{
/**
* @codeCoverageIgnore
* Description of this specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getDescription(): string
{
@@ -39,8 +44,10 @@ class RabobankDescription implements SpecificInterface
}
/**
* @codeCoverageIgnore
* Name of this specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getName(): string
{
@@ -48,9 +55,13 @@ class RabobankDescription implements SpecificInterface
}
/**
* Run the specific.
*
* @param array $row
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function run(array $row): array
{

View File

@@ -28,8 +28,10 @@ namespace FireflyIII\Import\Specifics;
class SnsDescription implements SpecificInterface
{
/**
* @codeCoverageIgnore
* Get description of specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getDescription(): string
{
@@ -37,8 +39,10 @@ class SnsDescription implements SpecificInterface
}
/**
* @codeCoverageIgnore
* Get name of specific.
*
* @return string
* @codeCoverageIgnore
*/
public static function getName(): string
{
@@ -46,6 +50,8 @@ class SnsDescription implements SpecificInterface
}
/**
* Run specific.
*
* @param array $row
*
* @return array

View File

@@ -28,16 +28,22 @@ namespace FireflyIII\Import\Specifics;
interface SpecificInterface
{
/**
* Get description.
*
* @return string
*/
public static function getDescription(): string;
/**
* Get name.
*
* @return string
*/
public static function getName(): string;
/**
* Run specific.
*
* @param array $row
*
* @return array