Improve test coverage and remove deprecated code.

2026-05-04 21:23:36 +00:00 · 2018-05-05 11:03:10 +02:00
parent 57be7f2905
commit bc7c3bb9b3
26 changed files with 1784 additions and 1093 deletions
--- a/tests/Unit/Import/Prerequisites/FakePrerequisitesTest.php
+++ b/tests/Unit/Import/Prerequisites/FakePrerequisitesTest.php
@@ -0,0 +1,174 @@
+<?php
+/**
+ * FakePrerequisitesTest.php
+ * Copyright (c) 2018 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Import\Prerequisites;
+
+
+use FireflyIII\Import\Prerequisites\FakePrerequisites;
+use FireflyIII\Models\Preference;
+use Mockery;
+use Preferences;
+use Tests\TestCase;
+
+/**
+ * Class FakePrerequisitesTest
+ */
+class FakePrerequisitesTest extends TestCase
+{
+    /**
+     * Bad API key length in preferences
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testGetViewParametersBadLength(): void
+    {
+        // API key should be empty:
+        $apiPref       = new Preference;
+        $apiPref->data = 'abc';
+
+        Preferences::shouldReceive('getForUser')
+                   ->withArgs([Mockery::any(), 'fake_api_key', false])->once()
+                   ->andReturn($apiPref);
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $result = $object->getViewParameters();
+        $this->assertEquals(['api_key' => ''], $result);
+    }
+
+    /**
+     * No API key in preference.
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testGetViewParametersDataNull(): void
+    {
+        // API key should be empty:
+        $apiPref       = new Preference;
+        $apiPref->data = null;
+
+        Preferences::shouldReceive('getForUser')
+                   ->withArgs([Mockery::any(), 'fake_api_key', false])->once()
+                   ->andReturn($apiPref);
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $result = $object->getViewParameters();
+        $this->assertEquals(['api_key' => ''], $result);
+    }
+
+    /**
+     * Good API key length in preferences
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testGetViewParametersGoodLength(): void
+    {
+        // API key should be empty:
+        $apiPref       = new Preference;
+        $apiPref->data = '123456789012345678901234567890AA';
+
+        Preferences::shouldReceive('getForUser')
+                   ->withArgs([Mockery::any(), 'fake_api_key', false])->twice()
+                   ->andReturn($apiPref);
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $result = $object->getViewParameters();
+        $this->assertEquals(['api_key' => '123456789012345678901234567890AA'], $result);
+    }
+
+    /**
+     * No preference at all.
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testGetViewParametersPrefNull(): void
+    {
+        Preferences::shouldReceive('getForUser')
+                   ->withArgs([Mockery::any(), 'fake_api_key', false])->once()
+                   ->andReturn(null);
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $result = $object->getViewParameters();
+        $this->assertEquals(['api_key' => ''], $result);
+    }
+
+    /**
+     * Also test hasApiKey but that one is covered.
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testIsComplete(): void
+    {
+        // API key should be empty:
+        $apiPref       = new Preference;
+        $apiPref->data = null;
+
+        Preferences::shouldReceive('getForUser')
+                   ->withArgs([Mockery::any(), 'fake_api_key', false])->once()
+                   ->andReturn($apiPref);
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $this->assertFalse($object->isComplete());
+    }
+
+    /**
+     * Also test hasApiKey but that one is covered.
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testStorePrerequisitesBad(): void
+    {
+        $data   = [
+            'api_key' => 'Hallo',
+        ];
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $messages = $object->storePrerequisites($data);
+        $this->assertCount(1, $messages);
+        $this->assertEquals('API key must be 32 chars.', $messages->first());
+    }
+
+    /**
+     * Also test hasApiKey but that one is covered.
+     *
+     * @covers \FireflyIII\Import\Prerequisites\FakePrerequisites
+     */
+    public function testStorePrerequisitesGood(): void
+    {
+        $data = [
+            'api_key' => '123456789012345678901234567890AA',
+        ];
+
+        Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'fake_api_key', '123456789012345678901234567890AA'])->once();
+
+        $object = new FakePrerequisites();
+        $object->setUser($this->user());
+        $messages = $object->storePrerequisites($data);
+        $this->assertCount(0, $messages);
+    }
+
+}