From bd221a59d68138cbc0c09c0ebda517d6d0c68714 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 16 Dec 2023 19:11:27 +0100 Subject: [PATCH] Fixes https://github.com/firefly-iii/firefly-iii/issues/8251 --- app/Handlers/Observer/BudgetObserver.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/Handlers/Observer/BudgetObserver.php b/app/Handlers/Observer/BudgetObserver.php index 1c8dc4791e..a3ef976b40 100644 --- a/app/Handlers/Observer/BudgetObserver.php +++ b/app/Handlers/Observer/BudgetObserver.php @@ -24,6 +24,7 @@ declare(strict_types=1); namespace FireflyIII\Handlers\Observer; use FireflyIII\Models\Budget; +use FireflyIII\Models\BudgetLimit; /** * Class BudgetObserver @@ -41,11 +42,18 @@ class BudgetObserver foreach ($budget->attachments()->get() as $attachment) { $attachment->delete(); } - - $budget->budgetlimits()->delete(); + $budgetLimits = $budget->budgetlimits()->get(); + /** @var BudgetLimit $budgetLimit */ + foreach($budgetLimits as $budgetLimit) { + // this loop exists so several events are fired. + $budgetLimit->delete(); + } $budget->notes()->delete(); $budget->autoBudgets()->delete(); + + // recalculate available budgets. + } }