From c0b7ef878a0e346490fdd0898458e8ddde990c34 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 31 Jul 2020 09:42:00 +0200 Subject: [PATCH] Code style fixes. --- app/Api/V1/Controllers/AccountController.php | 4 +--- app/Api/V1/Controllers/AttachmentController.php | 2 -- app/Api/V1/Controllers/Autocomplete/AccountController.php | 3 ++- .../V1/Controllers/Autocomplete/PiggyBankController.php | 1 + app/Api/V1/Controllers/Autocomplete/TagController.php | 1 - .../V1/Controllers/Autocomplete/TransactionController.php | 2 +- app/Api/V1/Controllers/AvailableBudgetController.php | 1 - app/Api/V1/Controllers/BillController.php | 2 +- app/Api/V1/Controllers/BudgetController.php | 3 ++- app/Api/V1/Controllers/BudgetLimitController.php | 3 ++- app/Api/V1/Controllers/CategoryController.php | 2 +- app/Api/V1/Controllers/Chart/AccountController.php | 2 ++ app/Api/V1/Controllers/Chart/AvailableBudgetController.php | 1 + app/Api/V1/Controllers/Chart/BudgetController.php | 2 ++ app/Api/V1/Controllers/Chart/CategoryController.php | 4 +++- app/Api/V1/Controllers/ConfigurationController.php | 3 --- app/Api/V1/Controllers/Controller.php | 3 --- app/Api/V1/Controllers/CurrencyController.php | 4 ++-- app/Api/V1/Controllers/CurrencyExchangeRateController.php | 1 - app/Api/V1/Controllers/LinkTypeController.php | 2 +- app/Api/V1/Controllers/ObjectGroupController.php | 2 -- app/Api/V1/Controllers/PiggyBankController.php | 2 -- app/Api/V1/Controllers/PreferenceController.php | 1 - app/Api/V1/Controllers/RecurrenceController.php | 1 + app/Api/V1/Controllers/RuleController.php | 2 +- app/Api/V1/Controllers/RuleGroupController.php | 1 + app/Api/V1/Controllers/SummaryController.php | 4 ++++ app/Api/V1/Controllers/TagController.php | 3 --- app/Api/V1/Controllers/TransactionController.php | 2 ++ app/Api/V1/Controllers/TransactionLinkController.php | 1 + app/Api/V1/Controllers/UserController.php | 1 - app/Api/V1/Requests/Autocomplete/AutocompleteRequest.php | 2 +- app/Api/V1/Requests/BillRequest.php | 1 - app/Api/V1/Requests/LinkTypeRequest.php | 1 - app/Api/V1/Requests/PiggyBankRequest.php | 1 - app/Api/V1/Requests/PiggyBankStoreRequest.php | 1 - app/Api/V1/Requests/PreferenceRequest.php | 1 - app/Api/V1/Requests/RuleGroupTestRequest.php | 1 - app/Api/V1/Requests/RuleGroupTriggerRequest.php | 1 - app/Api/V1/Requests/RuleStoreRequest.php | 1 - app/Api/V1/Requests/RuleTestRequest.php | 1 - app/Api/V1/Requests/RuleUpdateRequest.php | 1 - app/Api/V1/Requests/TagStoreRequest.php | 1 - app/Api/V1/Requests/TagUpdateRequest.php | 1 - app/Api/V1/Requests/TransactionLinkRequest.php | 2 -- app/Api/V1/Requests/TransactionUpdateRequest.php | 7 ++++++- app/Api/V1/Requests/UserUpdateRequest.php | 2 -- 47 files changed, 39 insertions(+), 52 deletions(-) diff --git a/app/Api/V1/Controllers/AccountController.php b/app/Api/V1/Controllers/AccountController.php index ab52fb15c0..572a8e1c02 100644 --- a/app/Api/V1/Controllers/AccountController.php +++ b/app/Api/V1/Controllers/AccountController.php @@ -45,11 +45,11 @@ use League\Fractal\Resource\Item; /** * Class AccountController. - * */ class AccountController extends Controller { use AccountFilter, TransactionFilter; + public const RESOURCE_KEY = 'accounts'; private AccountRepositoryInterface $repository; @@ -166,7 +166,6 @@ class AccountController extends Controller * * @return JsonResponse * @codeCoverageIgnore - * */ public function piggyBanks(Account $account): JsonResponse { @@ -246,7 +245,6 @@ class AccountController extends Controller * @param Account $account * * @return JsonResponse - * */ public function transactions(Request $request, Account $account): JsonResponse { diff --git a/app/Api/V1/Controllers/AttachmentController.php b/app/Api/V1/Controllers/AttachmentController.php index 61d10053c0..b89eaab5bf 100644 --- a/app/Api/V1/Controllers/AttachmentController.php +++ b/app/Api/V1/Controllers/AttachmentController.php @@ -28,7 +28,6 @@ use FireflyIII\Api\V1\Requests\AttachmentStoreRequest; use FireflyIII\Api\V1\Requests\AttachmentUpdateRequest; use FireflyIII\Exceptions\FireflyException; use FireflyIII\Helpers\Attachments\AttachmentHelperInterface; -use FireflyIII\Http\Middleware\IsDemoUser; use FireflyIII\Models\Attachment; use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface; use FireflyIII\Transformers\AttachmentTransformer; @@ -45,7 +44,6 @@ use function strlen; /** * Class AttachmentController. - * */ class AttachmentController extends Controller { diff --git a/app/Api/V1/Controllers/Autocomplete/AccountController.php b/app/Api/V1/Controllers/Autocomplete/AccountController.php index 17249f47c3..73b2136f4e 100644 --- a/app/Api/V1/Controllers/Autocomplete/AccountController.php +++ b/app/Api/V1/Controllers/Autocomplete/AccountController.php @@ -41,6 +41,7 @@ class AccountController extends Controller use AccountFilter; private array $balanceTypes; + private AccountRepositoryInterface $repository; @@ -60,7 +61,7 @@ class AccountController extends Controller return $next($request); } ); - $this->balanceTypes = [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE,]; + $this->balanceTypes = [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE, ]; } /** diff --git a/app/Api/V1/Controllers/Autocomplete/PiggyBankController.php b/app/Api/V1/Controllers/Autocomplete/PiggyBankController.php index 58f7290018..47ef2259c9 100644 --- a/app/Api/V1/Controllers/Autocomplete/PiggyBankController.php +++ b/app/Api/V1/Controllers/Autocomplete/PiggyBankController.php @@ -38,6 +38,7 @@ use Illuminate\Http\JsonResponse; class PiggyBankController extends Controller { private PiggyBankRepositoryInterface $piggyRepository; + private AccountRepositoryInterface $accountRepository; diff --git a/app/Api/V1/Controllers/Autocomplete/TagController.php b/app/Api/V1/Controllers/Autocomplete/TagController.php index 180badf8ce..5b2aeabc67 100644 --- a/app/Api/V1/Controllers/Autocomplete/TagController.php +++ b/app/Api/V1/Controllers/Autocomplete/TagController.php @@ -36,7 +36,6 @@ use Illuminate\Http\JsonResponse; */ class TagController extends Controller { - private TagRepositoryInterface $repository; diff --git a/app/Api/V1/Controllers/Autocomplete/TransactionController.php b/app/Api/V1/Controllers/Autocomplete/TransactionController.php index 7248999ce3..7a0a9b480b 100644 --- a/app/Api/V1/Controllers/Autocomplete/TransactionController.php +++ b/app/Api/V1/Controllers/Autocomplete/TransactionController.php @@ -38,8 +38,8 @@ use Illuminate\Support\Collection; */ class TransactionController extends Controller { - private JournalRepositoryInterface $repository; + private TransactionGroupRepositoryInterface $groupRepository; diff --git a/app/Api/V1/Controllers/AvailableBudgetController.php b/app/Api/V1/Controllers/AvailableBudgetController.php index 14e3335751..871b9d4101 100644 --- a/app/Api/V1/Controllers/AvailableBudgetController.php +++ b/app/Api/V1/Controllers/AvailableBudgetController.php @@ -38,7 +38,6 @@ use League\Fractal\Resource\Item; /** * Class AvailableBudgetController. - * */ class AvailableBudgetController extends Controller { diff --git a/app/Api/V1/Controllers/BillController.php b/app/Api/V1/Controllers/BillController.php index 3d906396aa..560713d202 100644 --- a/app/Api/V1/Controllers/BillController.php +++ b/app/Api/V1/Controllers/BillController.php @@ -44,11 +44,11 @@ use League\Fractal\Resource\Item; /** * Class BillController. - * */ class BillController extends Controller { use TransactionFilter; + /** @var BillRepositoryInterface The bill repository */ private $repository; diff --git a/app/Api/V1/Controllers/BudgetController.php b/app/Api/V1/Controllers/BudgetController.php index ee61047a27..595349f36a 100644 --- a/app/Api/V1/Controllers/BudgetController.php +++ b/app/Api/V1/Controllers/BudgetController.php @@ -47,13 +47,14 @@ use League\Fractal\Resource\Item; /** * Class BudgetController. - * */ class BudgetController extends Controller { use TransactionFilter; + /** @var BudgetLimitRepositoryInterface */ private $blRepository; + /** @var BudgetRepositoryInterface The budget repository */ private $repository; diff --git a/app/Api/V1/Controllers/BudgetLimitController.php b/app/Api/V1/Controllers/BudgetLimitController.php index f06c8fe2d5..d1f38d2403 100644 --- a/app/Api/V1/Controllers/BudgetLimitController.php +++ b/app/Api/V1/Controllers/BudgetLimitController.php @@ -44,13 +44,14 @@ use League\Fractal\Resource\Item; /** * Class BudgetLimitController. - * */ class BudgetLimitController extends Controller { use TransactionFilter; + /** @var BudgetLimitRepositoryInterface */ private $blRepository; + /** @var BudgetRepositoryInterface The budget repository */ private $repository; diff --git a/app/Api/V1/Controllers/CategoryController.php b/app/Api/V1/Controllers/CategoryController.php index 176d68cb4c..9f242de7e4 100644 --- a/app/Api/V1/Controllers/CategoryController.php +++ b/app/Api/V1/Controllers/CategoryController.php @@ -42,11 +42,11 @@ use League\Fractal\Resource\Item; /** * Class CategoryController. - * */ class CategoryController extends Controller { use TransactionFilter; + /** @var CategoryRepositoryInterface The category repository */ private $repository; diff --git a/app/Api/V1/Controllers/Chart/AccountController.php b/app/Api/V1/Controllers/Chart/AccountController.php index 26f4d0f709..d76ef86475 100644 --- a/app/Api/V1/Controllers/Chart/AccountController.php +++ b/app/Api/V1/Controllers/Chart/AccountController.php @@ -42,7 +42,9 @@ use Illuminate\Http\JsonResponse; class AccountController extends Controller { use ApiSupport; + private CurrencyRepositoryInterface $currencyRepository; + private AccountRepositoryInterface $repository; diff --git a/app/Api/V1/Controllers/Chart/AvailableBudgetController.php b/app/Api/V1/Controllers/Chart/AvailableBudgetController.php index 1ab6e1a40b..94ab3aaf6d 100644 --- a/app/Api/V1/Controllers/Chart/AvailableBudgetController.php +++ b/app/Api/V1/Controllers/Chart/AvailableBudgetController.php @@ -40,6 +40,7 @@ class AvailableBudgetController extends Controller { /** @var OperationsRepositoryInterface */ private $opsRepository; + /** @var BudgetRepositoryInterface */ private $repository; diff --git a/app/Api/V1/Controllers/Chart/BudgetController.php b/app/Api/V1/Controllers/Chart/BudgetController.php index b187c19d9d..d68c06ede1 100644 --- a/app/Api/V1/Controllers/Chart/BudgetController.php +++ b/app/Api/V1/Controllers/Chart/BudgetController.php @@ -41,7 +41,9 @@ use Illuminate\Support\Collection; class BudgetController extends Controller { private BudgetLimitRepositoryInterface $blRepository; + private OperationsRepositoryInterface $opsRepository; + private BudgetRepositoryInterface $repository; diff --git a/app/Api/V1/Controllers/Chart/CategoryController.php b/app/Api/V1/Controllers/Chart/CategoryController.php index b9cc279b50..6b88eb1ad6 100644 --- a/app/Api/V1/Controllers/Chart/CategoryController.php +++ b/app/Api/V1/Controllers/Chart/CategoryController.php @@ -40,8 +40,10 @@ class CategoryController extends Controller { /** @var CategoryRepositoryInterface */ private $categoryRepository; + /** @var NoCategoryRepositoryInterface */ private $noCatRepository; + /** @var OperationsRepositoryInterface */ private $opsRepository; @@ -92,7 +94,7 @@ class CategoryController extends Controller $categories = []; - foreach ([$spentWith, $spentWithout,] as $set) { + foreach ([$spentWith, $spentWithout, ] as $set) { foreach ($set as $currency) { foreach ($currency['categories'] as $category) { $categories[] = $category['name']; diff --git a/app/Api/V1/Controllers/ConfigurationController.php b/app/Api/V1/Controllers/ConfigurationController.php index 45749d794f..c9bf085b99 100644 --- a/app/Api/V1/Controllers/ConfigurationController.php +++ b/app/Api/V1/Controllers/ConfigurationController.php @@ -37,15 +37,12 @@ use Illuminate\Http\JsonResponse; */ class ConfigurationController extends Controller { - - /** @var UserRepositoryInterface The user repository */ private $repository; /** * ConfigurationController constructor. - * */ public function __construct() { diff --git a/app/Api/V1/Controllers/Controller.php b/app/Api/V1/Controllers/Controller.php index f2304ac4bf..856861dcea 100644 --- a/app/Api/V1/Controllers/Controller.php +++ b/app/Api/V1/Controllers/Controller.php @@ -39,7 +39,6 @@ use Symfony\Component\HttpFoundation\ParameterBag; * Class Controller. * * @codeCoverageIgnore - * */ class Controller extends BaseController { @@ -51,7 +50,6 @@ class Controller extends BaseController /** * Controller constructor. - * */ public function __construct() { @@ -63,7 +61,6 @@ class Controller extends BaseController * Method to help build URI's. * * @return string - * */ protected function buildParams(): string { diff --git a/app/Api/V1/Controllers/CurrencyController.php b/app/Api/V1/Controllers/CurrencyController.php index fd3918e669..ec6acf1aa5 100644 --- a/app/Api/V1/Controllers/CurrencyController.php +++ b/app/Api/V1/Controllers/CurrencyController.php @@ -21,7 +21,6 @@ declare(strict_types=1); - namespace FireflyIII\Api\V1\Controllers; use FireflyIII\Api\V1\Requests\CurrencyRequest; @@ -64,13 +63,14 @@ use League\Fractal\Resource\Item; /** * Class CurrencyController. - * */ class CurrencyController extends Controller { use AccountFilter, TransactionFilter; + /** @var CurrencyRepositoryInterface The currency repository */ private $repository; + /** @var UserRepositoryInterface The user repository */ private $userRepository; diff --git a/app/Api/V1/Controllers/CurrencyExchangeRateController.php b/app/Api/V1/Controllers/CurrencyExchangeRateController.php index 1aaafa8376..af3ab1ae04 100644 --- a/app/Api/V1/Controllers/CurrencyExchangeRateController.php +++ b/app/Api/V1/Controllers/CurrencyExchangeRateController.php @@ -46,7 +46,6 @@ class CurrencyExchangeRateController extends Controller /** * CurrencyExchangeRateController constructor. - * */ public function __construct() { diff --git a/app/Api/V1/Controllers/LinkTypeController.php b/app/Api/V1/Controllers/LinkTypeController.php index fc2b0e76c6..cbbea428ec 100644 --- a/app/Api/V1/Controllers/LinkTypeController.php +++ b/app/Api/V1/Controllers/LinkTypeController.php @@ -42,11 +42,11 @@ use League\Fractal\Resource\Item; /** * Class LinkTypeController. - * */ class LinkTypeController extends Controller { use TransactionFilter; + /** @var LinkTypeRepositoryInterface The link type repository */ private $repository; diff --git a/app/Api/V1/Controllers/ObjectGroupController.php b/app/Api/V1/Controllers/ObjectGroupController.php index 317793c592..2e68c799d7 100644 --- a/app/Api/V1/Controllers/ObjectGroupController.php +++ b/app/Api/V1/Controllers/ObjectGroupController.php @@ -39,7 +39,6 @@ use League\Fractal\Resource\Item; /** * Class GroupController. - * */ class ObjectGroupController extends Controller { @@ -123,7 +122,6 @@ class ObjectGroupController extends Controller * * @return JsonResponse * @codeCoverageIgnore - * */ public function piggyBanks(ObjectGroup $objectGroup): JsonResponse { diff --git a/app/Api/V1/Controllers/PiggyBankController.php b/app/Api/V1/Controllers/PiggyBankController.php index 8aa684075c..6f03988f79 100644 --- a/app/Api/V1/Controllers/PiggyBankController.php +++ b/app/Api/V1/Controllers/PiggyBankController.php @@ -40,11 +40,9 @@ use League\Fractal\Resource\Item; /** * Class PiggyBankController. - * */ class PiggyBankController extends Controller { - /** @var PiggyBankRepositoryInterface The piggy bank repository */ private $repository; diff --git a/app/Api/V1/Controllers/PreferenceController.php b/app/Api/V1/Controllers/PreferenceController.php index 2210e5810f..3fcb35b165 100644 --- a/app/Api/V1/Controllers/PreferenceController.php +++ b/app/Api/V1/Controllers/PreferenceController.php @@ -35,7 +35,6 @@ use League\Fractal\Resource\Collection as FractalCollection; use League\Fractal\Resource\Item; /** - * * Class PreferenceController */ class PreferenceController extends Controller diff --git a/app/Api/V1/Controllers/RecurrenceController.php b/app/Api/V1/Controllers/RecurrenceController.php index 2b0b377f05..c0caccca4c 100644 --- a/app/Api/V1/Controllers/RecurrenceController.php +++ b/app/Api/V1/Controllers/RecurrenceController.php @@ -48,6 +48,7 @@ use Log; class RecurrenceController extends Controller { use TransactionFilter; + /** @var RecurringRepositoryInterface The recurring transaction repository */ private $repository; diff --git a/app/Api/V1/Controllers/RuleController.php b/app/Api/V1/Controllers/RuleController.php index b05bf0de92..fc9b73fc5d 100644 --- a/app/Api/V1/Controllers/RuleController.php +++ b/app/Api/V1/Controllers/RuleController.php @@ -46,12 +46,12 @@ use Log; /** * Class RuleController - * */ class RuleController extends Controller { /** @var AccountRepositoryInterface Account repository */ private $accountRepository; + /** @var RuleRepositoryInterface The rule repository */ private $ruleRepository; diff --git a/app/Api/V1/Controllers/RuleGroupController.php b/app/Api/V1/Controllers/RuleGroupController.php index 56ae95378d..59a20b3c4b 100644 --- a/app/Api/V1/Controllers/RuleGroupController.php +++ b/app/Api/V1/Controllers/RuleGroupController.php @@ -54,6 +54,7 @@ class RuleGroupController extends Controller { /** @var AccountRepositoryInterface Account repository */ private $accountRepository; + /** @var RuleGroupRepositoryInterface The rule group repository */ private $ruleGroupRepository; diff --git a/app/Api/V1/Controllers/SummaryController.php b/app/Api/V1/Controllers/SummaryController.php index de7e6d7207..fd24fbc9d2 100644 --- a/app/Api/V1/Controllers/SummaryController.php +++ b/app/Api/V1/Controllers/SummaryController.php @@ -49,12 +49,16 @@ class SummaryController extends Controller { /** @var AvailableBudgetRepositoryInterface */ private $abRepository; + /** @var AccountRepositoryInterface */ private $accountRepository; + /** @var BillRepositoryInterface */ private $billRepository; + /** @var BudgetRepositoryInterface */ private $budgetRepository; + /** @var CurrencyRepositoryInterface */ private $currencyRepos; diff --git a/app/Api/V1/Controllers/TagController.php b/app/Api/V1/Controllers/TagController.php index 682b2fa20d..0ba1bc2698 100644 --- a/app/Api/V1/Controllers/TagController.php +++ b/app/Api/V1/Controllers/TagController.php @@ -23,8 +23,6 @@ declare(strict_types=1); namespace FireflyIII\Api\V1\Controllers; -use Carbon\Carbon; -use FireflyIII\Api\V1\Requests\DateRequest; use FireflyIII\Api\V1\Requests\TagStoreRequest; use FireflyIII\Api\V1\Requests\TagUpdateRequest; use FireflyIII\Helpers\Collector\GroupCollectorInterface; @@ -38,7 +36,6 @@ use FireflyIII\User; use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; use Illuminate\Pagination\LengthAwarePaginator; -use Illuminate\Support\Collection; use League\Fractal\Pagination\IlluminatePaginatorAdapter; use League\Fractal\Resource\Collection as FractalCollection; use League\Fractal\Resource\Item; diff --git a/app/Api/V1/Controllers/TransactionController.php b/app/Api/V1/Controllers/TransactionController.php index e878baebbb..c758eb9b4d 100644 --- a/app/Api/V1/Controllers/TransactionController.php +++ b/app/Api/V1/Controllers/TransactionController.php @@ -59,7 +59,9 @@ class TransactionController extends Controller use TransactionFilter; private TransactionGroupRepositoryInterface $groupRepository; + private JournalAPIRepositoryInterface $journalAPIRepository; + private JournalRepositoryInterface $repository; diff --git a/app/Api/V1/Controllers/TransactionLinkController.php b/app/Api/V1/Controllers/TransactionLinkController.php index 754a6feb69..7ed1c6d8cd 100644 --- a/app/Api/V1/Controllers/TransactionLinkController.php +++ b/app/Api/V1/Controllers/TransactionLinkController.php @@ -47,6 +47,7 @@ class TransactionLinkController extends Controller /** @var JournalRepositoryInterface The journal repository */ private $journalRepository; + /** @var LinkTypeRepositoryInterface The link type repository */ private $repository; diff --git a/app/Api/V1/Controllers/UserController.php b/app/Api/V1/Controllers/UserController.php index 832ff9ae56..bb87e1d4d4 100644 --- a/app/Api/V1/Controllers/UserController.php +++ b/app/Api/V1/Controllers/UserController.php @@ -39,7 +39,6 @@ use League\Fractal\Resource\Item; /** * Class UserController. - * */ class UserController extends Controller { diff --git a/app/Api/V1/Requests/Autocomplete/AutocompleteRequest.php b/app/Api/V1/Requests/Autocomplete/AutocompleteRequest.php index eec5b17ba6..c886037dc6 100644 --- a/app/Api/V1/Requests/Autocomplete/AutocompleteRequest.php +++ b/app/Api/V1/Requests/Autocomplete/AutocompleteRequest.php @@ -72,7 +72,7 @@ class AutocompleteRequest extends FormRequest public function rules(): array { return [ - 'limit' => 'min:0|max:1337' + 'limit' => 'min:0|max:1337', ]; } } diff --git a/app/Api/V1/Requests/BillRequest.php b/app/Api/V1/Requests/BillRequest.php index f9a0118daa..79d4d89548 100644 --- a/app/Api/V1/Requests/BillRequest.php +++ b/app/Api/V1/Requests/BillRequest.php @@ -81,7 +81,6 @@ class BillRequest extends FormRequest * The rules that the incoming request must be matched against. * * @return array - * */ public function rules(): array { diff --git a/app/Api/V1/Requests/LinkTypeRequest.php b/app/Api/V1/Requests/LinkTypeRequest.php index 2df955d218..c0d42b3e74 100644 --- a/app/Api/V1/Requests/LinkTypeRequest.php +++ b/app/Api/V1/Requests/LinkTypeRequest.php @@ -29,7 +29,6 @@ use Illuminate\Foundation\Http\FormRequest; use Illuminate\Validation\Rule; /** - * * Class LinkTypeRequest * * @codeCoverageIgnore diff --git a/app/Api/V1/Requests/PiggyBankRequest.php b/app/Api/V1/Requests/PiggyBankRequest.php index ad4a72c3cc..75d636e2de 100644 --- a/app/Api/V1/Requests/PiggyBankRequest.php +++ b/app/Api/V1/Requests/PiggyBankRequest.php @@ -31,7 +31,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; use Illuminate\Foundation\Http\FormRequest; /** - * * Class PiggyBankRequest * * @codeCoverageIgnore diff --git a/app/Api/V1/Requests/PiggyBankStoreRequest.php b/app/Api/V1/Requests/PiggyBankStoreRequest.php index 872accc702..a6d627cccc 100644 --- a/app/Api/V1/Requests/PiggyBankStoreRequest.php +++ b/app/Api/V1/Requests/PiggyBankStoreRequest.php @@ -28,7 +28,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; use Illuminate\Foundation\Http\FormRequest; /** - * * Class PiggyBankStoreRequest * * @codeCoverageIgnore diff --git a/app/Api/V1/Requests/PreferenceRequest.php b/app/Api/V1/Requests/PreferenceRequest.php index 8ebf2d1fe0..18852c8740 100644 --- a/app/Api/V1/Requests/PreferenceRequest.php +++ b/app/Api/V1/Requests/PreferenceRequest.php @@ -27,7 +27,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; use Illuminate\Foundation\Http\FormRequest; /** - * * Class PreferenceRequest * * @codeCoverageIgnore diff --git a/app/Api/V1/Requests/RuleGroupTestRequest.php b/app/Api/V1/Requests/RuleGroupTestRequest.php index 86d922a139..2d922f140a 100644 --- a/app/Api/V1/Requests/RuleGroupTestRequest.php +++ b/app/Api/V1/Requests/RuleGroupTestRequest.php @@ -22,7 +22,6 @@ declare(strict_types=1); - namespace FireflyIII\Api\V1\Requests; diff --git a/app/Api/V1/Requests/RuleGroupTriggerRequest.php b/app/Api/V1/Requests/RuleGroupTriggerRequest.php index fdcc59fb55..f4118b78b5 100644 --- a/app/Api/V1/Requests/RuleGroupTriggerRequest.php +++ b/app/Api/V1/Requests/RuleGroupTriggerRequest.php @@ -22,7 +22,6 @@ declare(strict_types=1); - namespace FireflyIII\Api\V1\Requests; diff --git a/app/Api/V1/Requests/RuleStoreRequest.php b/app/Api/V1/Requests/RuleStoreRequest.php index 8e40460236..26648dd18d 100644 --- a/app/Api/V1/Requests/RuleStoreRequest.php +++ b/app/Api/V1/Requests/RuleStoreRequest.php @@ -32,7 +32,6 @@ use function is_array; /** * Class RuleStoreRequest - * */ class RuleStoreRequest extends FormRequest { diff --git a/app/Api/V1/Requests/RuleTestRequest.php b/app/Api/V1/Requests/RuleTestRequest.php index 12797cb11f..f693ac5779 100644 --- a/app/Api/V1/Requests/RuleTestRequest.php +++ b/app/Api/V1/Requests/RuleTestRequest.php @@ -22,7 +22,6 @@ declare(strict_types=1); - namespace FireflyIII\Api\V1\Requests; diff --git a/app/Api/V1/Requests/RuleUpdateRequest.php b/app/Api/V1/Requests/RuleUpdateRequest.php index 658902f55d..51d285d6fc 100644 --- a/app/Api/V1/Requests/RuleUpdateRequest.php +++ b/app/Api/V1/Requests/RuleUpdateRequest.php @@ -32,7 +32,6 @@ use function is_array; /** * Class RuleUpdateRequest - * */ class RuleUpdateRequest extends FormRequest { diff --git a/app/Api/V1/Requests/TagStoreRequest.php b/app/Api/V1/Requests/TagStoreRequest.php index d0b487c1fc..c269357078 100644 --- a/app/Api/V1/Requests/TagStoreRequest.php +++ b/app/Api/V1/Requests/TagStoreRequest.php @@ -31,7 +31,6 @@ use Illuminate\Foundation\Http\FormRequest; * Class TagStoreRequest * * @codeCoverageIgnore - * */ class TagStoreRequest extends FormRequest { diff --git a/app/Api/V1/Requests/TagUpdateRequest.php b/app/Api/V1/Requests/TagUpdateRequest.php index 5cd7fbf925..08d87d5261 100644 --- a/app/Api/V1/Requests/TagUpdateRequest.php +++ b/app/Api/V1/Requests/TagUpdateRequest.php @@ -32,7 +32,6 @@ use Illuminate\Foundation\Http\FormRequest; * Class TagUpdateRequest * * @codeCoverageIgnore - * */ class TagUpdateRequest extends FormRequest { diff --git a/app/Api/V1/Requests/TransactionLinkRequest.php b/app/Api/V1/Requests/TransactionLinkRequest.php index e5f0eb1743..02f260e8e9 100644 --- a/app/Api/V1/Requests/TransactionLinkRequest.php +++ b/app/Api/V1/Requests/TransactionLinkRequest.php @@ -31,7 +31,6 @@ use Illuminate\Foundation\Http\FormRequest; use Illuminate\Validation\Validator; /** - * * Class TransactionLinkRequest */ class TransactionLinkRequest extends FormRequest @@ -65,7 +64,6 @@ class TransactionLinkRequest extends FormRequest } /** - * * The rules that the incoming request must be matched against. * * @return array diff --git a/app/Api/V1/Requests/TransactionUpdateRequest.php b/app/Api/V1/Requests/TransactionUpdateRequest.php index 892fb9e1a9..302f8f3700 100644 --- a/app/Api/V1/Requests/TransactionUpdateRequest.php +++ b/app/Api/V1/Requests/TransactionUpdateRequest.php @@ -44,14 +44,19 @@ class TransactionUpdateRequest extends FormRequest /** @var array Array values. */ private $arrayFields; + /** @var array Boolean values. */ private $booleanFields; + /** @var array Fields that contain date values. */ private $dateFields; + /** @var array Fields that contain integer values. */ private $integerFields; + /** @var array Fields that contain string values. */ private $stringFields; + /** @var array Fields that contain text (with newlines) */ private $textareaFields; @@ -130,7 +135,7 @@ class TransactionUpdateRequest extends FormRequest 'sepa_ep', 'sepa_ci', 'sepa_batch_id', - 'external_uri' + 'external_uri', ]; $this->booleanFields = [ 'reconciled', diff --git a/app/Api/V1/Requests/UserUpdateRequest.php b/app/Api/V1/Requests/UserUpdateRequest.php index 4931700eec..5fee8f3e24 100644 --- a/app/Api/V1/Requests/UserUpdateRequest.php +++ b/app/Api/V1/Requests/UserUpdateRequest.php @@ -24,10 +24,8 @@ declare(strict_types=1); namespace FireflyIII\Api\V1\Requests; -use FireflyIII\Repositories\User\UserRepositoryInterface; use FireflyIII\Rules\IsBoolean; use FireflyIII\Support\Request\ConvertsDataTypes; -use FireflyIII\User; use Illuminate\Foundation\Http\FormRequest;