Various code cleanup.

This commit is contained in:
James Cole
2021-06-13 07:04:18 +02:00
parent 85204de9aa
commit c98706fac0
24 changed files with 39 additions and 65 deletions

View File

@@ -253,7 +253,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
return [
'journals' => $journals,
'currency' => $currency,
'exists' => 0!==count($journals),
'exists' => !empty($journals),
'end' => $this->end->formatLocalized((string)trans('config.month_and_day', [], $locale)),
'endBalance' => app('steam')->balance($account, $this->end),
'dayBefore' => $date->formatLocalized((string)trans('config.month_and_day', [], $locale)),

View File

@@ -179,7 +179,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
*/
protected function getExpenses(): array
{
if (count($this->expenses) > 0) {
if (!empty($this->expenses)) {
Log::debug('Return previous set of expenses.');
return $this->expenses;

View File

@@ -188,7 +188,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
*/
protected function getExpenses(): array
{
if (count($this->expenses) > 0) {
if (!empty($this->expenses)) {
Log::debug('Return previous set of expenses.');
return $this->expenses;
@@ -213,7 +213,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
*/
protected function getIncome(): array
{
if (count($this->income) > 0) {
if (!empty($this->income)) {
return $this->income;
}