kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-20 08:30:06 +00:00
Code Issues Projects Releases Wiki Activity

Fix code quality with rector [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-11-09 09:07:14 +01:00
parent 38691d6fdf
commit d2610be790
262 changed files with 873 additions and 1186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Http/Controllers/ReportController.php
View File

@@ -23,6 +23,7 @@ declare(strict_types=1);
namespace FireflyIII\Http\Controllers;
use Illuminate\Support\Facades\Log;
use Carbon\Carbon;
use FireflyIII\Enums\AccountTypeEnum;
use FireflyIII\Exceptions\FireflyException;
@@ -192,11 +193,10 @@ class ReportController extends Controller
/**
* Show account report.
*
* @return string
*
* @throws FireflyException
*/
public function doubleReport(Collection $accounts, Collection $expense, Carbon $start, Carbon $end)
public function doubleReport(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): string
{
if ($end < $start) {
[$start, $end] = [$end, $start];
@@ -223,7 +223,7 @@ class ReportController extends Controller
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(AccountRepositoryInterface $repository)
public function index(AccountRepositoryInterface $repository): Factory|\Illuminate\Contracts\View\View
{
/** @var Carbon $start */
$start = clone session('first', today(config('app.timezone')));
@@ -255,7 +255,7 @@ class ReportController extends Controller
$accountList = implode(',', $accounts->pluck('id')->toArray());
$this->repository->cleanupBudgets();
return view('reports.index', compact('months', 'accounts', 'start', 'accountList', 'groupedAccounts', 'customFiscalYear'));
return view('reports.index', ['months' => $months, 'accounts' => $accounts, 'start' => $start, 'accountList' => $accountList, 'groupedAccounts' => $groupedAccounts, 'customFiscalYear' => $customFiscalYear]);
}
/**
@@ -296,7 +296,7 @@ class ReportController extends Controller
$double = implode(',', $request->getDoubleList()->pluck('id')->toArray());
if (0 === $request->getAccountList()->count()) {
app('log')->debug('Account count is zero');
Log::debug('Account count is zero');
session()->flash('error', (string) trans('firefly.select_at_least_one_account'));
return redirect(route('reports.index'));