mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2026-01-06 22:21:42 +00:00
Restore todo's
This commit is contained in:
@@ -76,7 +76,7 @@ trait ChartGeneration
|
||||
$chartData = [];
|
||||
/** @var Account $account */
|
||||
foreach ($accounts as $account) {
|
||||
// See reference nr. 33
|
||||
// TODO we can use getAccountCurrency instead.
|
||||
$currency = $repository->find((int) $accountRepos->getMetaValue($account, 'currency_id'));
|
||||
if (null === $currency) {
|
||||
$currency = $default;
|
||||
|
||||
@@ -115,7 +115,7 @@ trait ModelInformation
|
||||
*/
|
||||
protected function getTriggersForBill(Bill $bill): array // get info and augument
|
||||
{
|
||||
// See reference nr. 39
|
||||
// TODO duplicate code
|
||||
$operators = config('search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
|
||||
@@ -39,7 +39,7 @@ use Log;
|
||||
/**
|
||||
* Trait PeriodOverview.
|
||||
*
|
||||
* See reference nr. 36
|
||||
* TODO verify this all works as expected.
|
||||
*
|
||||
* - Always request start date and end date.
|
||||
* - Group expenses, income, etc. under this period.
|
||||
@@ -399,7 +399,7 @@ trait PeriodOverview
|
||||
}
|
||||
|
||||
/**
|
||||
* See reference nr. 37
|
||||
* TODO fix the date.
|
||||
*
|
||||
* Show period overview for no category view.
|
||||
*
|
||||
|
||||
@@ -298,7 +298,7 @@ trait RenderPartialViews
|
||||
*/
|
||||
protected function getCurrentTriggers(Rule $rule): array // get info from object and present.
|
||||
{
|
||||
// See reference nr. 38
|
||||
// TODO duplicated code.
|
||||
$operators = config('search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
|
||||
@@ -78,7 +78,7 @@ trait RuleManagement
|
||||
*/
|
||||
protected function getPreviousTriggers(Request $request): array
|
||||
{
|
||||
// See reference nr. 34
|
||||
// TODO duplicated code.
|
||||
$operators = config('search.operators');
|
||||
$triggers = [];
|
||||
foreach ($operators as $key => $operator) {
|
||||
@@ -124,7 +124,7 @@ trait RuleManagement
|
||||
*/
|
||||
protected function parseFromOperators(array $submittedOperators): array
|
||||
{
|
||||
// See reference nr. 35
|
||||
// TODO duplicated code.
|
||||
$operators = config('search.operators');
|
||||
$renderedEntries = [];
|
||||
$triggers = [];
|
||||
|
||||
Reference in New Issue
Block a user