From d3a2bf174dacf9b584caf9ab0f5644ccacf6fac2 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 1 Mar 2017 20:57:52 +0100 Subject: [PATCH] This fixes #605 --- app/Handlers/Events/StoredJournalEventHandler.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/app/Handlers/Events/StoredJournalEventHandler.php b/app/Handlers/Events/StoredJournalEventHandler.php index 14e4e2a438..c0e5e88014 100644 --- a/app/Handlers/Events/StoredJournalEventHandler.php +++ b/app/Handlers/Events/StoredJournalEventHandler.php @@ -57,9 +57,15 @@ class StoredJournalEventHandler /* * Get relevant data: */ - $piggyBank = $journal->user->piggyBanks()->where('piggy_banks.id', $piggyBankId)->first(['piggy_banks.*']); - $repetition = $piggyBank->piggyBankRepetitions()->relevantOnDate($journal->date)->first(); - $amount = $this->getExactAmount($journal, $piggyBank, $repetition); + $piggyBank = $journal->user->piggyBanks()->where('piggy_banks.id', $piggyBankId)->first(['piggy_banks.*']); + $repetition = $piggyBank->piggyBankRepetitions()->relevantOnDate($journal->date)->first(); + $amount = $this->getExactAmount($journal, $piggyBank, $repetition); + if (bccomp($amount, '0') === 0) { + Log::debug('Amount is zero, will not create event.'); + + return true; + } + $repetition->currentamount = bcadd($repetition->currentamount, $amount); $repetition->save();