Various code cleanup.

This commit is contained in:
James Cole
2021-05-24 08:54:58 +02:00
parent 815fd5ff6b
commit d60650cff2
63 changed files with 134 additions and 88 deletions

View File

@@ -57,7 +57,7 @@ class ConfirmPasswordController extends Controller
/**
* Create a new controller instance.
*
* @return void
* @throws FireflyException
*/
public function __construct()
{

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
/** @noinspection PhpDynamicAsStaticMethodCallInspection */
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Auth;
@@ -111,6 +110,7 @@ class ForgotPasswordController extends Controller
* @codeCoverageIgnore
*
* @return Factory|View
* @throws FireflyException
*/
public function showLinkRequestForm()
{

View File

@@ -73,14 +73,14 @@ class LoginController extends Controller
*
* @param Request $request
*
* @return RedirectResponse|\Illuminate\Http\Response|JsonResponse
* @return JsonResponse|RedirectResponse
*
* @throws ValidationException
*/
public function login(Request $request)
{
Log::channel('audit')->info(sprintf('User is trying to login using "%s"', $request->get('email')));
Log::info(sprintf('User is trying to login.'));
Log::info('User is trying to login.');
if ('ldap' === config('auth.providers.users.driver')) {
/** @var Adldap\Connections\Provider $provider */
Adldap::getProvider('default'); // @phpstan-ignore-line
@@ -161,7 +161,7 @@ class LoginController extends Controller
*
* @param Request $request
*
* @return Response
* @return void
*
* @throws ValidationException
*/
@@ -180,7 +180,10 @@ class LoginController extends Controller
/**
* Show the application's login form.
*
* @param Request $request
*
* @return Factory|\Illuminate\Http\Response|View
* @throws \FireflyIII\Exceptions\FireflyException
*/
public function showLoginForm(Request $request)
{

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
/** @noinspection PhpDynamicAsStaticMethodCallInspection */
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Auth;
@@ -78,6 +77,8 @@ class RegisterController extends Controller
* @param Request $request
*
* @return Factory|RedirectResponse|Redirector|View
* @throws FireflyException
* @throws \Illuminate\Validation\ValidationException
*/
public function register(Request $request)
{
@@ -123,6 +124,7 @@ class RegisterController extends Controller
* @param Request $request
*
* @return Factory|View
* @throws FireflyException
*/
public function showRegistrationForm(Request $request)
{

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
/** @noinspection PhpDynamicAsStaticMethodCallInspection */
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Auth;
@@ -120,10 +119,11 @@ class ResetPasswordController extends Controller
*
* If no token is present, display the link request form.
*
* @param Request $request
* @param string|null $token
* @param Request $request
* @param null $token
*
* @return Factory|View
* @throws FireflyException
*/
public function showResetForm(Request $request, $token = null)
{

View File

@@ -38,7 +38,7 @@ class TwoFactorController extends Controller
/**
* What to do if 2FA lost?
*
* @return mixed
* @return \Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
*/
public function lostTwoFactor()
{