kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-12 01:42:32 +00:00
Code Issues Projects Releases Wiki Activity

Fix all tests.

Browse Source
This commit is contained in:
James Cole
2018-03-24 06:08:50 +01:00
parent 3e22c9860e
commit dafddfa39a
72 changed files with 746 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Unit/TransactionRules/Triggers/HasAnyCategoryTest.php
View File

@@ -22,6 +22,7 @@ declare(strict_types=1);
namespace Tests\Unit\TransactionRules\Triggers;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Triggers\HasAnyCategory;
use Tests\TestCase;
@@ -54,6 +55,13 @@ class HasAnyCategoryTest extends TestCase
{
$journal = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
$journal->categories()->detach();
// also detach transactions:
/** @var Transaction $transaction */
foreach($journal->transactions as $transaction) {
$transaction->categories()->detach();
}
$this->assertEquals(0, $journal->categories()->count());
$trigger = HasAnyCategory::makeFromStrings('', false);
$result = $trigger->triggered($journal);

9
tests/Unit/TransactionRules/Triggers/HasNoCategoryTest.php
View File

@@ -22,6 +22,7 @@ declare(strict_types=1);
namespace Tests\Unit\TransactionRules\Triggers;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Triggers\HasNoCategory;
use Tests\TestCase;
@@ -54,6 +55,14 @@ class HasNoCategoryTest extends TestCase
{
$journal = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
$journal->categories()->detach();
// also detach transactions:
/** @var Transaction $transaction */
foreach ($journal->transactions as $transaction) {
$transaction->categories()->detach();
$this->assertEquals(0, $transaction->categories()->count());
}
$this->assertEquals(0, $journal->categories()->count());
$trigger = HasNoCategory::makeFromStrings('', false);

2
tests/Unit/Transformers/AccountTransformerTest.php
View File

@@ -153,6 +153,7 @@ class AccountTransformerTest extends TestCase
$accountRepos->shouldReceive('getMetaValue')->withArgs([Mockery::any(), 'currency_id'])->andReturn('1');
$accountRepos->shouldReceive('getMetaValue')->withArgs([Mockery::any(), 'ccType'])->andReturn('monthlyFull');
$accountRepos->shouldReceive('getMetaValue')->withArgs([Mockery::any(), 'accountNumber'])->andReturn('123');
$accountRepos->shouldReceive('getMetaValue')->withArgs([Mockery::any(), 'BIC'])->andReturn('123');
$accountRepos->shouldReceive('getNoteText')->andReturn($note->text);
$accountRepos->shouldReceive('getOpeningBalanceAmount')->andReturn(null);
$accountRepos->shouldReceive('getOpeningBalanceDate')->andReturn(null);
@@ -362,6 +363,7 @@ class AccountTransformerTest extends TestCase
$accountRepos->shouldReceive('getOpeningBalanceDate')->andReturn(null);
$accountRepos->shouldReceive('getMetaValue')->andReturn('1');
$accountRepos->shouldReceive('getNote')->andReturn('');
$accountRepos->shouldReceive('getNoteText')->withArgs([Mockery::any()])->andReturn('');
// make new account:
$account = Account::create(
[

15
tests/Unit/Transformers/TransactionTransformerTest.php
View File

@@ -89,6 +89,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -172,6 +173,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -255,6 +257,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -347,6 +350,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -438,6 +442,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
@@ -535,6 +540,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
@@ -631,6 +637,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions (negative opening balance).
@@ -715,6 +722,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions (positive opening balance).
@@ -799,6 +807,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions (negative reconciliation).
@@ -883,6 +892,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions (positive reconciliation).
@@ -968,6 +978,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
@@ -1067,6 +1078,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
@@ -1165,6 +1177,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -1248,6 +1261,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions
@@ -1331,6 +1345,7 @@ class TransactionTransformerTest extends TestCase
'description' => 'Some journal',
'date' => '2018-01-01',
'completed' => 1,
'tag_count' => 0,
]
);
// basic transactions