kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-09 03:08:09 +00:00
Code Issues Projects Releases Wiki Activity

Add checks to fix #3119

Browse Source
This commit is contained in:
James Cole
2020-02-14 05:39:21 +01:00
parent 50d4774907
commit db05839b87
1 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
app/Console/Commands/Correction/FixUnevenAmount.php
View File

@@ -90,11 +90,40 @@ class FixUnevenAmount extends Command
} }
/** @var Transaction $source */ /** @var Transaction $source */
$source = $journal->transactions()->where('amount', '<', 0)->first(); $source = $journal->transactions()->where('amount', '<', 0)->first();
if (null === $source) {
$this->error(
sprintf(
'Journal #%d ("%s") has no source transaction. It will be deleted to maintain database consistency.', $journal->id ?? 0,
$journal->description ?? ''
)
);
Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
TransactionJournal::where('id', $journal-> ?? 0)->forceDelete();
return;
}
$amount = bcmul('-1', (string)$source->amount); $amount = bcmul('-1', (string)$source->amount);
// fix amount of destination: // fix amount of destination:
/** @var Transaction $destination */ /** @var Transaction $destination */
$destination = $journal->transactions()->where('amount', '>', 0)->first(); $destination = $journal->transactions()->where('amount', '>', 0)->first();
if (null === $destination) {
$this->error(
sprintf(
'Journal #%d ("%s") has no destination transaction. It will be deleted to maintain database consistency.', $journal->id ?? 0,
$journal->description ?? ''
)
);
Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
TransactionJournal::where('id', $journal-> ?? 0)->forceDelete();
return;
}
$destination->amount = $amount; $destination->amount = $amount;
$destination->save(); $destination->save();