kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-06 22:21:42 +00:00
Code Issues Projects Releases Wiki Activity

Various phpstan fixes.

Browse Source
This commit is contained in:
James Cole
2023-11-04 06:52:40 +01:00
parent 633d84449a
commit dc45131f73
20 changed files with 39 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Repositories/Journal/JournalRepository.php
View File

@@ -104,7 +104,7 @@ class JournalRepository implements JournalRepositoryInterface
*/
public function getDestinationAccount(TransactionJournal $journal): Account
{
/** @var Transaction $transaction */
/** @var Transaction|null $transaction */
$transaction = $journal->transactions()->with('account')->where('amount', '>', 0)->first();
if (null === $transaction) {
throw new FireflyException(sprintf('Your administration is broken. Transaction journal #%d has no destination transaction.', $journal->id));
@@ -142,7 +142,7 @@ class JournalRepository implements JournalRepositoryInterface
*/
public function getLast(): ?TransactionJournal
{
/** @var TransactionJournal $entry */
/** @var TransactionJournal|null $entry */
$entry = $this->user->transactionJournals()->orderBy('date', 'DESC')->first(['transaction_journals.*']);
$result = null;
if (null !== $entry) {
@@ -159,13 +159,9 @@ class JournalRepository implements JournalRepositoryInterface
*/
public function getLinkNoteText(TransactionJournalLink $link): string
{
/** @var Note $note */
/** @var Note|null $note */
$note = $link->notes()->first();
if (null !== $note) {
return $note->text ?? '';
}
return '';
return (string)$note?->text;
}
/**