Improve test coverage.

2026-05-04 13:16:31 +00:00 · 2018-09-02 20:13:25 +02:00
parent 96dd89fbeb
commit de754ca4e0
31 changed files with 861 additions and 385 deletions
--- a/tests/Feature/Controllers/Recurring/EditControllerTest.php
+++ b/tests/Feature/Controllers/Recurring/EditControllerTest.php
@@ -0,0 +1,125 @@
+<?php
+/**
+ * EditControllerTest.php
+ * Copyright (c) 2018 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\Feature\Controllers\Recurring;
+
+use Carbon\Carbon;
+use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
+use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
+use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
+use Illuminate\Support\Collection;
+use Log;
+use Tests\TestCase;
+
+/**
+ *
+ * Class EditControllerTest
+ */
+class EditControllerTest extends TestCase
+{
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::debug(sprintf('Now in %s.', \get_class($this)));
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\Recurring\EditController
+     */
+    public function testEdit(): void
+    {
+        $recurringRepos = $this->mock(RecurringRepositoryInterface::class);
+        $budgetRepos    = $this->mock(BudgetRepositoryInterface::class);
+
+        $recurringRepos->shouldReceive('setUser');
+        $recurringRepos->shouldReceive('getNoteText')->andReturn('Note!');
+        $recurringRepos->shouldReceive('repetitionDescription')->andReturn('dunno');
+        $recurringRepos->shouldReceive('getXOccurrences')->andReturn([]);
+        $budgetRepos->shouldReceive('findNull')->andReturn($this->user()->budgets()->first());
+
+
+        $budgetRepos->shouldReceive('getActiveBudgets')->andReturn(new Collection)->once();
+        //\Amount::shouldReceive('getDefaultCurrency')->andReturn(TransactionCurrency::find(1));
+
+
+        $this->be($this->user());
+        $response = $this->get(route('recurring.edit', [1]));
+        $response->assertStatus(200);
+        $response->assertSee('<ol class="breadcrumb">');
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\Recurring\EditController
+     * @covers \FireflyIII\Http\Requests\RecurrenceFormRequest
+     */
+    public function testUpdate(): void
+    {
+        $recurringRepos = $this->mock(RecurringRepositoryInterface::class);
+        $budgetRepos    = $this->mock(BudgetRepositoryInterface::class);
+        $categoryRepos  = $this->mock(CategoryRepositoryInterface::class);
+
+        $recurringRepos->shouldReceive('update')->once();
+
+        $tomorrow   = Carbon::create()->addDays(2);
+        $recurrence = $this->user()->recurrences()->first();
+        $data       = [
+            'id'                      => $recurrence->id,
+            'title'                   => 'hello',
+            'first_date'              => $tomorrow->format('Y-m-d'),
+            'repetition_type'         => 'daily',
+            'skip'                    => 0,
+            'recurring_description'   => 'Some descr',
+            'active'                  => '1',
+            'apply_rules'             => '1',
+            'return_to_edit'          => '1',
+            // mandatory for transaction:
+            'transaction_description' => 'Some descr',
+            'transaction_type'        => 'withdrawal',
+            'transaction_currency_id' => '1',
+            'amount'                  => '30',
+            // mandatory account info:
+            'source_id'               => '1',
+            'source_name'             => '',
+            'destination_id'          => '',
+            'destination_name'        => 'Some Expense',
+
+            // optional fields:
+            'budget_id'               => '1',
+            'category'                => 'CategoryA',
+            'tags'                    => 'A,B,C',
+            'create_another'          => '1',
+            'repetition_end'          => 'times',
+            'repetitions'             => 3,
+        ];
+
+
+        $this->be($this->user());
+        $response = $this->post(route('recurring.update', [1]), $data);
+        $response->assertStatus(302);
+        $response->assertSessionHas('success');
+    }
+
+}