kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 12:12:18 +00:00
Code Issues Projects Releases Wiki Activity

Remove TODO's, add some suppressors for code quality.

Browse Source
This commit is contained in:
James Cole
2018-07-25 19:43:02 +02:00
parent 02272f7db0
commit e8c9554dd6
35 changed files with 196 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Repositories/Rule/RuleRepository.php
View File

@@ -32,6 +32,8 @@ use Illuminate\Support\Collection;
/**
* Class RuleRepository.
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class RuleRepository implements RuleRepositoryInterface
{
@@ -386,7 +388,7 @@ class RuleRepository implements RuleRepositoryInterface
private function storeActions(Rule $rule, array $data): bool
{
$order = 1;
foreach ($data['rule-actions'] as $index => $action) {
foreach ($data['rule-actions'] as $action) {
$value = $action['value'] ?? '';
$stopProcessing = $action['stop-processing'] ?? false;
@@ -422,7 +424,7 @@ class RuleRepository implements RuleRepositoryInterface
];
$this->storeTrigger($rule, $triggerValues);
foreach ($data['rule-triggers'] as $index => $trigger) {
foreach ($data['rule-triggers'] as $trigger) {
$value = $trigger['value'] ?? '';
$stopProcessing = $trigger['stop-processing'] ?? false;