kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 12:12:18 +00:00
Code Issues Projects Releases Wiki Activity

Remove TODO's, add some suppressors for code quality.

Browse Source
This commit is contained in:
James Cole
2018-07-25 19:43:02 +02:00
parent 02272f7db0
commit e8c9554dd6
35 changed files with 196 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/Validation/FireflyValidator.php
View File

@@ -242,8 +242,6 @@ class FireflyValidator extends Validator
}
/**
* TODO lots of if-else because of API calls.
*
* @param $attribute
*
* @return bool
@@ -305,8 +303,6 @@ class FireflyValidator extends Validator
}
/**
* TODO This method uses a lot of if-then to handle the API calls as well. Fix.
*
* @param $attribute
*
* @return bool
@@ -449,19 +445,6 @@ class FireflyValidator extends Validator
return false;
}
/**
* TODO fill me.
*
* @param $attribute
* @param $value
* @param $parameters
*
* @return bool
*/
public function validateRepetitionMoment($attribute, $value, $parameters): bool {
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*
@@ -578,8 +561,6 @@ class FireflyValidator extends Validator
}
/**
* TODO this method needs a lot of logic to be able to handle API calls. Fix that.
*
* @param int $index
*
* @return string
@@ -595,8 +576,6 @@ class FireflyValidator extends Validator
}
/**
* TODO this method needs a lot of logic to be able to handle API calls. Fix that.
*
* @param int $index
*
* @return string
@@ -612,8 +591,6 @@ class FireflyValidator extends Validator
}
/**
* TODO this method needs a lot of logic to be able to handle API calls. Fix that.
*
* @param int $index
*
* @return string
@@ -629,8 +606,6 @@ class FireflyValidator extends Validator
}
/**
* TODO this method needs a lot of logic to be able to handle API calls. Fix that.
*
* @param int $index
*
* @return string