Various fixes for tests and code quality.

app/Http/Controllers/Account/CreateController.php

@@ -36,11 +36,11 @@ use Illuminate\Http\Request;
  */
 class CreateController extends Controller
 {
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $repository;
 
     /**
-     *
+     * CreateController constructor.
      */
     public function __construct()
     {
@@ -60,6 +60,8 @@ class CreateController extends Controller
     }
 
     /**
+     * Create a new account.
+     *
      * @param Request     $request
      * @param string|null $what
      *
@@ -90,6 +92,8 @@ class CreateController extends Controller
 
 
     /**
+     * Store the new account.
+     *
      * @param AccountFormRequest $request
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector

app/Http/Controllers/Account/DeleteController.php

@@ -30,16 +30,15 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use Illuminate\Http\Request;
 
 /**
- *
  * Class DeleteController
  */
 class DeleteController extends Controller
 {
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $repository;
 
     /**
-     *
+     * DeleteController constructor.
      */
     public function __construct()
     {
@@ -59,6 +58,8 @@ class DeleteController extends Controller
     }
 
     /**
+     * Delete account screen.
+     *
      * @param Account $account
      *
      * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
@@ -77,6 +78,8 @@ class DeleteController extends Controller
     }
 
     /**
+     * Delete the account.
+     *
      * @param Request $request
      * @param Account $account
      *

app/Http/Controllers/Account/EditController.php

@@ -37,13 +37,13 @@ use Illuminate\Http\Request;
  */
 class EditController extends Controller
 {
-    /** @var CurrencyRepositoryInterface */
+    /** @var CurrencyRepositoryInterface The currency repository */
     private $currencyRepos;
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $repository;
 
     /**
-     *
+     * EditController constructor.
      */
     public function __construct()
     {
@@ -64,6 +64,8 @@ class EditController extends Controller
     }
 
     /**
+     * Edit account overview.
+     *
      * @param Request                    $request
      * @param Account                    $account
      * @param AccountRepositoryInterface $repository
@@ -120,6 +122,8 @@ class EditController extends Controller
 
 
     /**
+     * Update the account.
+     *
      * @param AccountFormRequest $request
      * @param Account            $account
      *

app/Http/Controllers/Account/IndexController.php

@@ -36,11 +36,11 @@ use Illuminate\Pagination\LengthAwarePaginator;
  */
 class IndexController extends Controller
 {
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $repository;
 
     /**
-     *
+     * IndexController constructor.
      */
     public function __construct()
     {
@@ -60,6 +60,8 @@ class IndexController extends Controller
     }
 
     /**
+     * Show list of accounts.
+     *
      * @param Request $request
      * @param string  $what
      *
@@ -106,6 +108,8 @@ class IndexController extends Controller
 
 
     /**
+     * Find the ID in a given array. Return '0' of not there (amount).
+     *
      * @param array $array
      * @param int   $entryId
      *

app/Http/Controllers/Account/ReconcileController.php

@@ -45,15 +45,15 @@ use Log;
  */
 class ReconcileController extends Controller
 {
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $accountRepos;
-    /** @var CurrencyRepositoryInterface */
+    /** @var CurrencyRepositoryInterface The currency repository */
     private $currencyRepos;
-    /** @var JournalRepositoryInterface */
+    /** @var JournalRepositoryInterface Journals and transactions overview */
     private $repository;
 
     /**
-     *
+     * ReconcileController constructor.
      */
     public function __construct()
     {
@@ -74,6 +74,8 @@ class ReconcileController extends Controller
     }
 
     /**
+     * Edit a reconciliation.
+     *
      * @param TransactionJournal $journal
      *
      * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
@@ -110,6 +112,8 @@ class ReconcileController extends Controller
     }
 
     /**
+     * Reconciliation overview.
+     *
      * @param Account     $account
      * @param Carbon|null $start
      * @param Carbon|null $end
@@ -168,6 +172,8 @@ class ReconcileController extends Controller
     }
 
     /**
+     * Show a single reconciliation.
+     *
      * @param TransactionJournal $journal
      *
      * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Illuminate\View\View
@@ -193,6 +199,8 @@ class ReconcileController extends Controller
 
     /** @noinspection MoreThanThreeArgumentsInspection */
     /**
+     * Submit a new reconciliation.
+     *
      * @param ReconciliationStoreRequest $request
      * @param Account                    $account
      * @param Carbon                     $start
@@ -278,6 +286,8 @@ class ReconcileController extends Controller
 
 
     /**
+     * Update a reconciliation.
+     *
      * @param ReconciliationUpdateRequest $request
      * @param TransactionJournal          $journal
      *
@@ -359,6 +369,8 @@ class ReconcileController extends Controller
     }
 
     /**
+     * Redirect user to the original asset account.
+     *
      * @param Account $account
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector

app/Http/Controllers/Account/ShowController.php

@@ -45,13 +45,13 @@ use View;
  */
 class ShowController extends Controller
 {
-    /** @var CurrencyRepositoryInterface */
+    /** @var CurrencyRepositoryInterface The currency repository */
     private $currencyRepos;
-    /** @var AccountRepositoryInterface */
+    /** @var AccountRepositoryInterface The account repository */
     private $repository;
 
     /**
-     *
+     * ShowController constructor.
      */
     public function __construct()
     {
@@ -241,6 +241,8 @@ class ShowController extends Controller
     }
 
     /**
+     * Redirect to the original account.
+     *
      * @param Account $account
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector