kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 20:22:07 +00:00
Code Issues Projects Releases Wiki Activity

Small code quality improvements.

Browse Source
This commit is contained in:
James Cole
2018-07-14 23:22:08 +02:00
parent 5dad569d62
commit f1462dbd3d
7 changed files with 49 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/Http/Controllers/Chart/PiggyBankController.php
View File

@@ -29,6 +29,7 @@ use FireflyIII\Models\PiggyBank;
use FireflyIII\Models\PiggyBankEvent;
use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
use FireflyIII\Support\CacheProperties;
use FireflyIII\Support\Http\Controllers\DateCalculation;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Collection;
@@ -37,6 +38,7 @@ use Illuminate\Support\Collection;
*/
class PiggyBankController extends Controller
{
use DateCalculation;
/** @var GeneratorInterface */
protected $generator;
@@ -81,17 +83,7 @@ class PiggyBankController extends Controller
$oldest = $startDate->lt($firstDate) ? $startDate : $firstDate;
$today = new Carbon;
// depending on diff, do something with range of chart.
$step = '1D';
$months = $oldest->diffInMonths($today);
if ($months > 3) {
$step = '1W'; // @codeCoverageIgnore
}
if ($months > 24) {
$step = '1M'; // @codeCoverageIgnore
}
if ($months > 100) {
$step = '1Y'; // @codeCoverageIgnore
}
$step = $this->calculateStep($oldest, $today);
$chartData = [];
while ($oldest <= $today) {